swift-swiftlang-swift-signature-next-comment

A painting is a person's account of this edit as text, recorded independently of the node mapping - a rendering often has several equally defensible answers where the mapping has one. Deletions and insertions carry no position on the opposite side in a painting, so that panel draws no caret for them.

Before1// {"kind":"typecheck","original":"5c733d48","signature":"getTypeForSymbolRange(swift::rewriting::Symbol const*, swift::rewriting::Symbol const*, llvm::ArrayRef<swift::GenericTypeParamType*>, swift::rewriting::PropertyMap const&)","signatureAssert":"Assertion failed: (std::find(conformsTo.begin(), conformsTo.end(), symbol.getProtocol()) != conformsTo.end()), function getTypeForSymbolRange"}
2// RUN: not --crash %target-swift-frontend -typecheck %s
3protocol a {
4  associatedtype b
5}
6protocol c {
7  associatedtype b
…lines 8–16 unchanged (9 lines)

After1// {"kind":"typecheck","original":"5c733d48","signature":"getTypeForSymbolRange(swift::rewriting::Symbol const*, swift::rewriting::Symbol const*, llvm::ArrayRef<swift::GenericTypeParamType*>, swift::rewriting::PropertyMap const&)","signatureAssert":"Assertion failed: (std::find(conformsTo.begin(), conformsTo.end(), symbol.getProtocol()) != conformsTo.end()), function getTypeForSymbolRange","signatureNext":"PropertyMap::getTypeForTerm"}
2// RUN: not --crash %target-swift-frontend -typecheck %s
3protocol a {
4  associatedtype b
5}
6protocol c {
7  associatedtype b
…lines 8–16 unchanged (9 lines)

Before1// {"kind":"typecheck","original":"5c733d48","signature":"getTypeForSymbolRange(swift::rewriting::Symbol const*, swift::rewriting::Symbol const*, llvm::ArrayRef<swift::GenericTypeParamType*>, swift::rewriting::PropertyMap const&)","signatureAssert":"Assertion failed: (std::find(conformsTo.begin(), conformsTo.end(), symbol.getProtocol()) != conformsTo.end()), function getTypeForSymbolRange"}
2// RUN: not --crash %target-swift-frontend -typecheck %s
3protocol a {
4  associatedtype b
5}
6protocol c {
7  associatedtype b
…lines 8–16 unchanged (9 lines)

After1// {"kind":"typecheck","original":"5c733d48","signature":"getTypeForSymbolRange(swift::rewriting::Symbol const*, swift::rewriting::Symbol const*, llvm::ArrayRef<swift::GenericTypeParamType*>, swift::rewriting::PropertyMap const&)","signatureAssert":"Assertion failed: (std::find(conformsTo.begin(), conformsTo.end(), symbol.getProtocol()) != conformsTo.end()), function getTypeForSymbolRange","signatureNext":"PropertyMap::getTypeForTerm"}
2// RUN: not --crash %target-swift-frontend -typecheck %s
3protocol a {
4  associatedtype b
5}
6protocol c {
7  associatedtype b
…lines 8–16 unchanged (9 lines)

Before

source_file

comment "// {\"kind\":\"typecheck\",\"original\":\"5c733d48\",\"signature\":\"ge"...

comment "// RUN: not --crash %target-swift-frontend -typecheck %s"

protocol_declaration

protocol "protocol"

type_identifier "a"

protocol_body

{ "{"

associatedtype_declaration

associatedtype "associatedtype"

type_identifier "b"

} "}"

ERROR

protocol "protocol"

simple_identifier "c"

{ "{"

associatedtype_declaration

associatedtype "associatedtype"

type_identifier "b"

value_binding_pattern

var "var"

simple_identifier "d"

type_annotation

: ":"

user_type

type_identifier "b"

class_declaration

struct "struct"

type_identifier "e"

: ":"

inheritance_specifier

user_type

type_identifier "c"

class_body

{ "{"

} ""

ERROR

simple_identifier "d"

: ":"

some "some"

ERROR "a"

class_declaration (+55 nodes collapsed)

After

source_file

comment "// {\"kind\":\"typecheck\",\"original\":\"5c733d48\",\"signature\":\"ge"...

comment "// RUN: not --crash %target-swift-frontend -typecheck %s"

protocol_declaration

protocol "protocol"

type_identifier "a"

protocol_body

{ "{"

associatedtype_declaration

associatedtype "associatedtype"

type_identifier "b"

} "}"

ERROR

protocol "protocol"

simple_identifier "c"

{ "{"

associatedtype_declaration

associatedtype "associatedtype"

type_identifier "b"

value_binding_pattern

var "var"

simple_identifier "d"

type_annotation

: ":"

user_type

type_identifier "b"

class_declaration

struct "struct"

type_identifier "e"

: ":"

inheritance_specifier

user_type

type_identifier "c"

class_body

{ "{"

} ""

ERROR

simple_identifier "d"

: ":"

some "some"

ERROR "a"

class_declaration (+55 nodes collapsed)

Keybindings

j / k: next / previous visible node (tree panels)
h / l: collapse / expand the focused node
g / G: jump to first / last visible node
Tab: switch focus between Before/After panels
/: search: jump to next node whose text contains a given string
a: jump the other panel to this node's mapped counterpart
i: hide identical matches, showing only inserted/deleted/updated nodes and their ancestors
v: cycle the view: split / code only / tree only
p: cycle what the code view renders: the node mapping, then each human painting
r: mark this fixture as reviewed, or forget the mark (kept in this browser only)
n: open a random fixture not yet marked as reviewed
?: toggle this help