swift-nextcloud-ios-actual-control-flow-change

A painting is a person's account of this edit as text, recorded independently of the node mapping - a rendering often has several equally defensible answers where the mapping has one. Deletions and insertions carry no position on the opposite side in a painting, so that panel draws no caret for them.

Before…lines 1–140 unchanged (140 lines)
                                                                    selector: "",
                                                                    status: self.global.metadataStatusNormal)
      }
144
      return(error)
  }
147
  // MARK: -
149
  func downloadSuccessMetadataItems(_ metadataItems: [MetadataItem]) async -> [String] {
      guard !metadataItems.isEmpty else {
          return []
      }
      let ocIds = Array(Set(metadataItems.compactMap { $0.ocId }))
…lines 155–216 unchanged (62 lines)
                                                         etag: etag,
                                                         date: date,
                                                         dateLastModified: dateLastModified,
                                                         length: length,
                                                         task: task,
                                                         error: error)
          return
          #endif
225
          if error == .success {
              nkLog(success: "Downloaded file: " + fileName)
              await NCMetadataStore.shared.setDownloadCompleted(fileName: fileName, serverUrl: serverUrl, taskIdentifier: task.taskIdentifier, etag: etag)
          } else {
              await NCMetadataStore.shared.removeItem(fileName: fileName, serverUrl: serverUrl, taskIdentifier: task.taskIdentifier)
231
              guard let metadata = await NCManageDatabase.shared.getMetadataAsync(predicate: NSPredicate(format: "serverUrl == %@ AND fileName == %@", serverUrl, fileName)) else {
                  return
              }
              await NextcloudKit.shared.nkCommonInstance.appendServerErrorAccount(metadata.account, errorCode: error.errorCode)
236
…lines 237–327 unchanged (91 lines)

After…lines 1–140 unchanged (140 lines)
                                                                    selector: "",
                                                                    status: self.global.metadataStatusNormal)
      }
144
      return(error)
  }
147
  // MARK: - DOWNLOAD SUCCESS
149
  func downloadSuccessMetadataItems(_ metadataItems: [MetadataItem]) async -> [String] {
      guard !metadataItems.isEmpty else {
          return []
      }
      let ocIds = Array(Set(metadataItems.compactMap { $0.ocId }))
…lines 155–216 unchanged (62 lines)
                                                         etag: etag,
                                                         date: date,
                                                         dateLastModified: dateLastModified,
                                                         length: length,
                                                         task: task,
                                                         error: error)
          #else
          if error == .success {
              nkLog(success: "Downloaded file: " + fileName)
              await NCMetadataStore.shared.setDownloadCompleted(fileName: fileName, serverUrl: serverUrl, taskIdentifier: task.taskIdentifier, etag: etag)
          } else {
              // Remove Item on MetadataStore
              await NCMetadataStore.shared.removeItem(fileName: fileName, serverUrl: serverUrl, taskIdentifier: task.taskIdentifier)
230
              guard let metadata = await NCManageDatabase.shared.getMetadataAsync(predicate: NSPredicate(format: "serverUrl == %@ AND fileName == %@", serverUrl, fileName)) else {
                  return
              }
              await NextcloudKit.shared.nkCommonInstance.appendServerErrorAccount(metadata.account, errorCode: error.errorCode)
…lines 235–265 unchanged (31 lines)
                                                  metadata: metadata,
                                                  error: error)
                      }
                  }
              }
          }
          #endif
      }
  }
275
  func downloadingFinish(_ session: URLSession, downloadTask: URLSessionDownloadTask, didFinishDownloadingTo location: URL) {
      if let httpResponse = (downloadTask.response as? HTTPURLResponse) {
          if httpResponse.statusCode >= 200 && httpResponse.statusCode < 300,
…lines 279–327 unchanged (49 lines)

Before…lines 1–140 unchanged (140 lines)
                                                                    selector: "",
                                                                    status: self.global.metadataStatusNormal)
      }
144
      return(error)
  }
147
  // MARK: -
149
  func downloadSuccessMetadataItems(_ metadataItems: [MetadataItem]) async -> [String] {
      guard !metadataItems.isEmpty else {
          return []
      }
      let ocIds = Array(Set(metadataItems.compactMap { $0.ocId }))
…lines 155–216 unchanged (62 lines)
                                                         etag: etag,
                                                         date: date,
                                                         dateLastModified: dateLastModified,
                                                         length: length,
                                                         task: task,
                                                         error: error)
          return
          #endif
225
          if error == .success {
              nkLog(success: "Downloaded file: " + fileName)
              await NCMetadataStore.shared.setDownloadCompleted(fileName: fileName, serverUrl: serverUrl, taskIdentifier: task.taskIdentifier, etag: etag)
          } else {
              await NCMetadataStore.shared.removeItem(fileName: fileName, serverUrl: serverUrl, taskIdentifier: task.taskIdentifier)
231
              guard let metadata = await NCManageDatabase.shared.getMetadataAsync(predicate: NSPredicate(format: "serverUrl == %@ AND fileName == %@", serverUrl, fileName)) else {
                  return
              }
              await NextcloudKit.shared.nkCommonInstance.appendServerErrorAccount(metadata.account, errorCode: error.errorCode)
236
…lines 237–327 unchanged (91 lines)

After…lines 1–140 unchanged (140 lines)
                                                                    selector: "",
                                                                    status: self.global.metadataStatusNormal)
      }
144
      return(error)
  }
147
  // MARK: - DOWNLOAD SUCCESS
149
  func downloadSuccessMetadataItems(_ metadataItems: [MetadataItem]) async -> [String] {
      guard !metadataItems.isEmpty else {
          return []
      }
      let ocIds = Array(Set(metadataItems.compactMap { $0.ocId }))
…lines 155–216 unchanged (62 lines)
                                                         etag: etag,
                                                         date: date,
                                                         dateLastModified: dateLastModified,
                                                         length: length,
                                                         task: task,
                                                         error: error)
          #else
          if error == .success {
              nkLog(success: "Downloaded file: " + fileName)
              await NCMetadataStore.shared.setDownloadCompleted(fileName: fileName, serverUrl: serverUrl, taskIdentifier: task.taskIdentifier, etag: etag)
          } else {
              // Remove Item on MetadataStore
              await NCMetadataStore.shared.removeItem(fileName: fileName, serverUrl: serverUrl, taskIdentifier: task.taskIdentifier)
230
              guard let metadata = await NCManageDatabase.shared.getMetadataAsync(predicate: NSPredicate(format: "serverUrl == %@ AND fileName == %@", serverUrl, fileName)) else {
                  return
              }
              await NextcloudKit.shared.nkCommonInstance.appendServerErrorAccount(metadata.account, errorCode: error.errorCode)
…lines 235–265 unchanged (31 lines)
                                                  metadata: metadata,
                                                  error: error)
                      }
                  }
              }
          }
          #endif
      }
  }
275
  func downloadingFinish(_ session: URLSession, downloadTask: URLSessionDownloadTask, didFinishDownloadingTo location: URL) {
      if let httpResponse = (downloadTask.response as? HTTPURLResponse) {
          if httpResponse.statusCode >= 200 && httpResponse.statusCode < 300,
…lines 279–327 unchanged (49 lines)

Before…lines 1–140 unchanged (140 lines)
                                                                    selector: "",
                                                                    status: self.global.metadataStatusNormal)
      }
144
      return(error)
  }
147
  // MARK: -
149
  func downloadSuccessMetadataItems(_ metadataItems: [MetadataItem]) async -> [String] {
      guard !metadataItems.isEmpty else {
          return []
      }
      let ocIds = Array(Set(metadataItems.compactMap { $0.ocId }))
…lines 155–216 unchanged (62 lines)
                                                         etag: etag,
                                                         date: date,
                                                         dateLastModified: dateLastModified,
                                                         length: length,
                                                         task: task,
                                                         error: error)
          return
          #endif
225
          if error == .success {
              nkLog(success: "Downloaded file: " + fileName)
              await NCMetadataStore.shared.setDownloadCompleted(fileName: fileName, serverUrl: serverUrl, taskIdentifier: task.taskIdentifier, etag: etag)
          } else {
              await NCMetadataStore.shared.removeItem(fileName: fileName, serverUrl: serverUrl, taskIdentifier: task.taskIdentifier)
231
              guard let metadata = await NCManageDatabase.shared.getMetadataAsync(predicate: NSPredicate(format: "serverUrl == %@ AND fileName == %@", serverUrl, fileName)) else {
                  return
              }
              await NextcloudKit.shared.nkCommonInstance.appendServerErrorAccount(metadata.account, errorCode: error.errorCode)
236
…lines 237–327 unchanged (91 lines)

After…lines 1–140 unchanged (140 lines)
                                                                    selector: "",
                                                                    status: self.global.metadataStatusNormal)
      }
144
      return(error)
  }
147
  // MARK: - DOWNLOAD SUCCESS
149
  func downloadSuccessMetadataItems(_ metadataItems: [MetadataItem]) async -> [String] {
      guard !metadataItems.isEmpty else {
          return []
      }
      let ocIds = Array(Set(metadataItems.compactMap { $0.ocId }))
…lines 155–216 unchanged (62 lines)
                                                         etag: etag,
                                                         date: date,
                                                         dateLastModified: dateLastModified,
                                                         length: length,
                                                         task: task,
                                                         error: error)
          #else
          if error == .success {
              nkLog(success: "Downloaded file: " + fileName)
              await NCMetadataStore.shared.setDownloadCompleted(fileName: fileName, serverUrl: serverUrl, taskIdentifier: task.taskIdentifier, etag: etag)
          } else {
              // Remove Item on MetadataStore
              await NCMetadataStore.shared.removeItem(fileName: fileName, serverUrl: serverUrl, taskIdentifier: task.taskIdentifier)
230
              guard let metadata = await NCManageDatabase.shared.getMetadataAsync(predicate: NSPredicate(format: "serverUrl == %@ AND fileName == %@", serverUrl, fileName)) else {
                  return
              }
              await NextcloudKit.shared.nkCommonInstance.appendServerErrorAccount(metadata.account, errorCode: error.errorCode)
…lines 235–265 unchanged (31 lines)
                                                  metadata: metadata,
                                                  error: error)
                      }
                  }
              }
          }
          #endif
      }
  }
275
  func downloadingFinish(_ session: URLSession, downloadTask: URLSessionDownloadTask, didFinishDownloadingTo location: URL) {
      if let httpResponse = (downloadTask.response as? HTTPURLResponse) {
          if httpResponse.statusCode >= 200 && httpResponse.statusCode < 300,
…lines 279–327 unchanged (49 lines)

Before

source_file

comment "// SPDX-FileCopyrightText: Nextcloud GmbH"

comment "// SPDX-FileCopyrightText: 2024 Marino Faggiana"

comment "// SPDX-License-Identifier: GPL-3.0-or-later"

import_declaration

import "import"

identifier

simple_identifier "UIKit"

import_declaration

import "import"

identifier

simple_identifier "NextcloudKit"

import_declaration

import "import"

identifier

simple_identifier "Alamofire"

import_declaration

import "import"

identifier

simple_identifier "Queuer"

import_declaration

import "import"

identifier

simple_identifier "RealmSwift"

class_declaration

extension "extension"

user_type

type_identifier "NCNetworking"

class_body

{ "{"

comment "// MARK: - Download file in foreground"

function_declaration (+1110 nodes collapsed)

comment "// MARK: - Download file in background"

function_declaration (+516 nodes collapsed)

comment "// MARK: -"

function_declaration (+555 nodes collapsed)

comment "// MARK: - Download NextcloudKitDelegate"

function_declaration

func "func"

simple_identifier "downloadComplete"

( "("

parameter

simple_identifier "fileName"

: ":"

user_type

type_identifier "String"

, ","

parameter

simple_identifier "serverUrl"

: ":"

user_type

type_identifier "String"

, ","

parameter

simple_identifier "etag"

: ":"

optional_type

user_type

type_identifier "String"

? "?"

, ","

parameter

simple_identifier "date"

: ":"

optional_type

user_type

type_identifier "Date"

? "?"

, ","

parameter

simple_identifier "dateLastModified"

: ":"

optional_type

user_type

type_identifier "Date"

? "?"

, ","

parameter

simple_identifier "length"

: ":"

user_type

type_identifier "Int64"

, ","

parameter

simple_identifier "task"

: ":"

user_type

type_identifier "URLSessionTask"

, ","

parameter

simple_identifier "error"

: ":"

user_type

type_identifier "NKError"

) ")"

function_body

{ "{"

statements

call_expression

simple_identifier "Task"

call_suffix

lambda_literal

{ "{"

statements

await_expression (+26 nodes collapsed)

directive

#if "#if"

simple_identifier "EXTENSION_FILE_PROVIDER_EXTENSION"

await_expression (+63 nodes collapsed)

control_transfer_statement

return "return"

directive

#endif "#endif"

if_statement

if "if"

equality_expression

simple_identifier "error"

== "=="

prefix_expression

. "."

simple_identifier "success"

{ "{"

statements (+61 nodes collapsed)

} "}"

else "else"

{ "{"

statements (+606 nodes collapsed)

} "}"

function_declaration (+369 nodes collapsed)

function_declaration (+267 nodes collapsed)

} "}"

After

source_file

comment "// SPDX-FileCopyrightText: Nextcloud GmbH"

comment "// SPDX-FileCopyrightText: 2024 Marino Faggiana"

comment "// SPDX-License-Identifier: GPL-3.0-or-later"

import_declaration

import "import"

identifier

simple_identifier "UIKit"

import_declaration

import "import"

identifier

simple_identifier "NextcloudKit"

import_declaration

import "import"

identifier

simple_identifier "Alamofire"

import_declaration

import "import"

identifier

simple_identifier "Queuer"

import_declaration

import "import"

identifier

simple_identifier "RealmSwift"

class_declaration

extension "extension"

user_type

type_identifier "NCNetworking"

class_body

{ "{"

comment "// MARK: - Download file in foreground"

function_declaration (+1110 nodes collapsed)

comment "// MARK: - Download file in background"

function_declaration (+516 nodes collapsed)

comment "// MARK: - DOWNLOAD SUCCESS"

function_declaration (+555 nodes collapsed)

comment "// MARK: - Download NextcloudKitDelegate"

function_declaration

func "func"

simple_identifier "downloadComplete"

( "("

parameter

simple_identifier "fileName"

: ":"

user_type

type_identifier "String"

, ","

parameter

simple_identifier "serverUrl"

: ":"

user_type

type_identifier "String"

, ","

parameter

simple_identifier "etag"

: ":"

optional_type

user_type

type_identifier "String"

? "?"

, ","

parameter

simple_identifier "date"

: ":"

optional_type

user_type

type_identifier "Date"

? "?"

, ","

parameter

simple_identifier "dateLastModified"

: ":"

optional_type

user_type

type_identifier "Date"

? "?"

, ","

parameter

simple_identifier "length"

: ":"

user_type

type_identifier "Int64"

, ","

parameter

simple_identifier "task"

: ":"

user_type

type_identifier "URLSessionTask"

, ","

parameter

simple_identifier "error"

: ":"

user_type

type_identifier "NKError"

) ")"

function_body

{ "{"

statements

call_expression

simple_identifier "Task"

call_suffix

lambda_literal

{ "{"

statements

await_expression (+26 nodes collapsed)

directive

#if "#if"

simple_identifier "EXTENSION_FILE_PROVIDER_EXTENSION"

await_expression (+63 nodes collapsed)

directive

#else "#else"

if_statement

if "if"

equality_expression

simple_identifier "error"

== "=="

prefix_expression

. "."

simple_identifier "success"

{ "{"

statements (+61 nodes collapsed)

} "}"

else "else"

{ "{"

comment "// Remove Item on MetadataStore"

statements (+606 nodes collapsed)

} "}"

directive

#endif "#endif"

} "}"

function_declaration (+369 nodes collapsed)

function_declaration (+267 nodes collapsed)

} "}"