Before

…lines 1–258 unchanged (258 lines)
259 # Even more restricted checking for files that import files that break pychecker and have unused parameters
260 travis_fold start "pychecker_c"
261 pychecker --quiet --limit 500 --blacklist $PYCHECKER_BLACKLIST --only --no-argsused $(find ./ -name "*.py" -and ! \( -name "*_pb2.py" -or -name "OlaClient.py" -or -name "ola_candidate_ports.py" -or -name "ola_universe_info.py" -or -name "rdm_snapshot.py" -or -name "ClientWrapper.py" -or -name "PidStore.py" -or -name "enforce_licence.py" -or -name "ola_mon.py" -or -name "TestLogger.py" -or -name "TestRunner.py" -or -name "rdm_model_collector.py" -or -name "rdm_responder_test.py" -or -name "rdm_test_server.py" -or -wholename "./include/ola/gen_callbacks.py" -or -wholename "./tools/rdm/ResponderTest.py" -or -wholename "./tools/rdm/TestHelpers.py" \) | xargs)
262 travis_fold end "pychecker_c"
263 # Special case checking for some python 3 compatibility workarounds
264 travis_fold start "pychecker_d"
265 pychecker --quiet --limit 500 --no-shadowbuiltin --no-noeffect ./include/ola/gen_callbacks.py ./tools/rdm/ResponderTest.py
266 travis_fold end "pychecker_d"
267 # Special case checking for some python 3 compatibility workarounds that import files that break pychecker
268 travis_fold start "pychecker_e"
269 pychecker --quiet --limit 500 --only --no-shadowbuiltin --no-noeffect ./tools/rdm/TestHelpers.py
270 travis_fold end "pychecker_e"
271elif [[ $TASK = 'pychecker-wip' ]]; then
272 travis_fold start "autoreconf"
273 autoreconf -i;
274 travis_fold end "autoreconf"
275 travis_fold start "configure"
276 ./configure --enable-rdm-tests;
277 travis_fold end "configure"
…lines 278–315 unchanged (38 lines)

After

…lines 1–259 unchanged (259 lines)
260 travis_fold start "pychecker_c"
261 pychecker --quiet --limit 500 --blacklist $PYCHECKER_BLACKLIST --only --no-argsused $(find ./ -name "*.py" -and ! \( -name "*_pb2.py" -or -name "OlaClient.py" -or -name "ola_candidate_ports.py" -or -name "ola_universe_info.py" -or -name "rdm_snapshot.py" -or -name "ClientWrapper.py" -or -name "PidStore.py" -or -name "enforce_licence.py" -or -name "ola_mon.py" -or -name "TestLogger.py" -or -name "TestRunner.py" -or -name "rdm_model_collector.py" -or -name "rdm_responder_test.py" -or -name "rdm_test_server.py" -or -wholename "./include/ola/gen_callbacks.py" -or -wholename "./tools/rdm/ResponderTest.py" -or -wholename "./tools/rdm/TestHelpers.py" \) | xargs)
262 travis_fold end "pychecker_c"
263 # Special case checking for some python 3 compatibility workarounds
264 travis_fold start "pychecker_d"
265 pychecker --quiet --limit 500 --no-shadowbuiltin --no-noeffect ./include/ola/gen_callbacks.py
266 travis_fold end "pychecker_d"
267 # Special case checking for some python 3 compatibility workarounds that import files that break pychecker
268 travis_fold start "pychecker_e"
269 pychecker --quiet --limit 500 --only --no-shadowbuiltin --no-noeffect ./tools/rdm/TestHelpers.py
270 travis_fold end "pychecker_e"
271 # Extra special case checking for some python 3 compatibility workarounds that import files that break pychecker and have unused parameters
272 travis_fold start "pychecker_f"
273 pychecker --quiet --limit 500 --only --no-argsused --no-shadowbuiltin --no-noeffect ./tools/rdm/ResponderTest.py
274 travis_fold end "pychecker_f"
275elif [[ $TASK = 'pychecker-wip' ]]; then
276 travis_fold start "autoreconf"
277 autoreconf -i;
278 travis_fold end "autoreconf"
279 travis_fold start "configure"
280 ./configure --enable-rdm-tests;
…lines 281–319 unchanged (39 lines)

Before

program
comment "#!/bin/bash"
comment "# This script is triggered from the script section of .travi"...
comment "# It runs the appropriate commands depending on the task req"...
command
command_name
word "set"
word "-e"
variable_assignment
variable_name "CPP_LINT_URL"
= "="
string
" "\""
string_content "https://raw.githubusercontent.com/google/styleguide/gh-pages"...
" "\""
; ";"
variable_assignment
variable_name "COVERITY_SCAN_BUILD_URL"
= "="
string
" "\""
string_content "https://scan.coverity.com/scripts/travisci_build_coverity_sc"...
" "\""
variable_assignment
variable_name "PYCHECKER_BLACKLIST"
= "="
string
" "\""
string_content "threading,unittest,cmd,optparse,google,google.protobuf,ssl,f"...
" "\""
variable_assignment
variable_name "SPELLINGBLACKLIST"
= "="
command_substitution
$( "$("
redirected_statement
command
command_name
word "cat"
heredoc_redirect
<<- "<<-"
heredoc_start "BLACKLIST"
heredoc_body "-wholename \"./.codespellignorewords\" -or \\\n -wholename "...
heredoc_end "BLACKLIST"
) ")"
if_statement
if "if"
test_command
[[ "[["
binary_expression
simple_expansion
$ "$"
variable_name "TASK"
= "="
raw_string "'lint'"
]] "]]"
; ";"
then "then"
comment "# run the lint tool only if it is the requested task"
command
command_name
word "travis_fold"
word "start"
string
" "\""
string_content "autoreconf"
" "\""
command
command_name
word "autoreconf"
word "-i"
; ";"
command
command_name
word "travis_fold"
word "end"
string
" "\""
string_content "autoreconf"
" "\""
command
command_name
word "./configure"
word "--enable-rdm-tests"
word "--enable-ja-rule"
word "--enable-e133"
; ";"
comment "# the following is a bit of a hack to build the files normal"...
comment "# the build, so they are present for linting to run against"
command
command_name
word "travis_fold"
word "start"
string
" "\""
string_content "make_builtfiles"
" "\""
command
command_name
word "make"
word "builtfiles"
; ";"
command
command_name
word "travis_fold"
word "end"
string
" "\""
string_content "make_builtfiles"
" "\""
comment "# first check we've not got any generic NOLINTs"
comment "# count the number of generic NOLINTs"
variable_assignment (+27 nodes collapsed)
if_statement (+66 nodes collapsed)
; ";"
comment "# run the cpplint tool, fetching it if necessary"
command
command_name
word "make"
word "cpplint"
elif_clause (+104 nodes collapsed)
elif_clause (+194 nodes collapsed)
elif_clause (+175 nodes collapsed)
elif_clause (+202 nodes collapsed)
elif_clause (+155 nodes collapsed)
elif_clause (+100 nodes collapsed)
elif_clause (+54 nodes collapsed)
elif_clause (+47 nodes collapsed)
elif_clause (+82 nodes collapsed)
elif_clause
elif "elif"
test_command
[[ "[["
binary_expression
simple_expansion
$ "$"
variable_name "TASK"
= "="
raw_string "'pychecker'"
]] "]]"
; ";"
then "then"
command
command_name
word "travis_fold"
word "start"
string
" "\""
string_content "autoreconf"
" "\""
command
command_name
word "autoreconf"
word "-i"
; ";"
command
command_name
word "travis_fold"
word "end"
string
" "\""
string_content "autoreconf"
" "\""
command
command_name
word "travis_fold"
word "start"
string
" "\""
string_content "configure"
" "\""
command
command_name
word "./configure"
word "--enable-rdm-tests"
; ";"
command
command_name
word "travis_fold"
word "end"
string
" "\""
string_content "configure"
" "\""
comment "# the following is a bit of a hack to build the files normal"...
comment "# the build, so they are present for pychecker to run agains"...
command
command_name
word "travis_fold"
word "start"
string
" "\""
string_content "make_builtfiles"
" "\""
command
command_name
word "make"
word "builtfiles"
; ";"
command
command_name
word "travis_fold"
word "end"
string
" "\""
string_content "make_builtfiles"
" "\""
variable_assignment
variable_name "PYTHONPATH"
= "="
concatenation
word "./python/:"
simple_expansion
$ "$"
variable_name "PYTHONPATH"
declaration_command
export "export"
variable_name "PYTHONPATH"
command
command_name
word "mkdir"
word "./python/ola/testing/"
command
command_name
word "ln"
word "-s"
word "./tools/rdm"
word "./python/ola/testing/rdm"
command
command_name
word "travis_fold"
word "start"
string
" "\""
string_content "pychecker_a"
" "\""
command (+128 nodes collapsed)
command
command_name
word "travis_fold"
word "end"
string
" "\""
string_content "pychecker_a"
" "\""
comment "# More restricted checking for files that import files that "...
command
command_name
word "travis_fold"
word "start"
string
" "\""
string_content "pychecker_b"
" "\""
command (+66 nodes collapsed)
command
command_name
word "travis_fold"
word "end"
string
" "\""
string_content "pychecker_b"
" "\""
comment "# Even more restricted checking for files that import files "...
command
command_name
word "travis_fold"
word "start"
string
" "\""
string_content "pychecker_c"
" "\""
command (+134 nodes collapsed)
command
command_name
word "travis_fold"
word "end"
string
" "\""
string_content "pychecker_c"
" "\""
comment "# Special case checking for some python 3 compatibility work"...
command
command_name
word "travis_fold"
word "start"
string
" "\""
string_content "pychecker_d"
" "\""
command
command_name
word "pychecker"
word "--quiet"
word "--limit"
number "500"
word "--no-shadowbuiltin"
word "--no-noeffect"
word "./include/ola/gen_callbacks.py"
word "./tools/rdm/ResponderTest.py"
command
command_name
word "travis_fold"
word "end"
string
" "\""
string_content "pychecker_d"
" "\""
comment "# Special case checking for some python 3 compatibility work"...
command
command_name
word "travis_fold"
word "start"
string
" "\""
string_content "pychecker_e"
" "\""
command
command_name
word "pychecker"
word "--quiet"
word "--limit"
number "500"
word "--only"
word "--no-shadowbuiltin"
word "--no-noeffect"
word "./tools/rdm/TestHelpers.py"
command
command_name
word "travis_fold"
word "end"
string
" "\""
string_content "pychecker_e"
" "\""
elif_clause (+147 nodes collapsed)
else_clause (+190 nodes collapsed)
fi "fi"

After

program
comment "#!/bin/bash"
comment "# This script is triggered from the script section of .travi"...
comment "# It runs the appropriate commands depending on the task req"...
command
command_name
word "set"
word "-e"
variable_assignment
variable_name "CPP_LINT_URL"
= "="
string
" "\""
string_content "https://raw.githubusercontent.com/google/styleguide/gh-pages"...
" "\""
; ";"
variable_assignment
variable_name "COVERITY_SCAN_BUILD_URL"
= "="
string
" "\""
string_content "https://scan.coverity.com/scripts/travisci_build_coverity_sc"...
" "\""
variable_assignment
variable_name "PYCHECKER_BLACKLIST"
= "="
string
" "\""
string_content "threading,unittest,cmd,optparse,google,google.protobuf,ssl,f"...
" "\""
variable_assignment
variable_name "SPELLINGBLACKLIST"
= "="
command_substitution
$( "$("
redirected_statement
command
command_name
word "cat"
heredoc_redirect
<<- "<<-"
heredoc_start "BLACKLIST"
heredoc_body "-wholename \"./.codespellignorewords\" -or \\\n -wholename "...
heredoc_end "BLACKLIST"
) ")"
if_statement
if "if"
test_command
[[ "[["
binary_expression
simple_expansion
$ "$"
variable_name "TASK"
= "="
raw_string "'lint'"
]] "]]"
; ";"
then "then"
comment "# run the lint tool only if it is the requested task"
command
command_name
word "travis_fold"
word "start"
string
" "\""
string_content "autoreconf"
" "\""
command
command_name
word "autoreconf"
word "-i"
; ";"
command
command_name
word "travis_fold"
word "end"
string
" "\""
string_content "autoreconf"
" "\""
command
command_name
word "./configure"
word "--enable-rdm-tests"
word "--enable-ja-rule"
word "--enable-e133"
; ";"
comment "# the following is a bit of a hack to build the files normal"...
comment "# the build, so they are present for linting to run against"
command
command_name
word "travis_fold"
word "start"
string
" "\""
string_content "make_builtfiles"
" "\""
command
command_name
word "make"
word "builtfiles"
; ";"
command
command_name
word "travis_fold"
word "end"
string
" "\""
string_content "make_builtfiles"
" "\""
comment "# first check we've not got any generic NOLINTs"
comment "# count the number of generic NOLINTs"
variable_assignment (+27 nodes collapsed)
if_statement (+66 nodes collapsed)
; ";"
comment "# run the cpplint tool, fetching it if necessary"
command
command_name
word "make"
word "cpplint"
elif_clause (+104 nodes collapsed)
elif_clause (+194 nodes collapsed)
elif_clause (+175 nodes collapsed)
elif_clause (+202 nodes collapsed)
elif_clause (+155 nodes collapsed)
elif_clause (+100 nodes collapsed)
elif_clause (+54 nodes collapsed)
elif_clause (+47 nodes collapsed)
elif_clause (+82 nodes collapsed)
elif_clause
elif "elif"
test_command
[[ "[["
binary_expression
simple_expansion
$ "$"
variable_name "TASK"
= "="
raw_string "'pychecker'"
]] "]]"
; ";"
then "then"
command
command_name
word "travis_fold"
word "start"
string
" "\""
string_content "autoreconf"
" "\""
command
command_name
word "autoreconf"
word "-i"
; ";"
command
command_name
word "travis_fold"
word "end"
string
" "\""
string_content "autoreconf"
" "\""
command
command_name
word "travis_fold"
word "start"
string
" "\""
string_content "configure"
" "\""
command
command_name
word "./configure"
word "--enable-rdm-tests"
; ";"
command
command_name
word "travis_fold"
word "end"
string
" "\""
string_content "configure"
" "\""
comment "# the following is a bit of a hack to build the files normal"...
comment "# the build, so they are present for pychecker to run agains"...
command
command_name
word "travis_fold"
word "start"
string
" "\""
string_content "make_builtfiles"
" "\""
command
command_name
word "make"
word "builtfiles"
; ";"
command
command_name
word "travis_fold"
word "end"
string
" "\""
string_content "make_builtfiles"
" "\""
variable_assignment
variable_name "PYTHONPATH"
= "="
concatenation
word "./python/:"
simple_expansion
$ "$"
variable_name "PYTHONPATH"
declaration_command
export "export"
variable_name "PYTHONPATH"
command
command_name
word "mkdir"
word "./python/ola/testing/"
command
command_name
word "ln"
word "-s"
word "./tools/rdm"
word "./python/ola/testing/rdm"
command
command_name
word "travis_fold"
word "start"
string
" "\""
string_content "pychecker_a"
" "\""
command (+128 nodes collapsed)
command
command_name
word "travis_fold"
word "end"
string
" "\""
string_content "pychecker_a"
" "\""
comment "# More restricted checking for files that import files that "...
command
command_name
word "travis_fold"
word "start"
string
" "\""
string_content "pychecker_b"
" "\""
command (+66 nodes collapsed)
command
command_name
word "travis_fold"
word "end"
string
" "\""
string_content "pychecker_b"
" "\""
comment "# Even more restricted checking for files that import files "...
command
command_name
word "travis_fold"
word "start"
string
" "\""
string_content "pychecker_c"
" "\""
command (+134 nodes collapsed)
command
command_name
word "travis_fold"
word "end"
string
" "\""
string_content "pychecker_c"
" "\""
comment "# Special case checking for some python 3 compatibility work"...
command
command_name
word "travis_fold"
word "start"
string
" "\""
string_content "pychecker_d"
" "\""
command
command_name
word "pychecker"
word "--quiet"
word "--limit"
number "500"
word "--no-shadowbuiltin"
word "--no-noeffect"
word "./include/ola/gen_callbacks.py"
command
command_name
word "travis_fold"
word "end"
string
" "\""
string_content "pychecker_d"
" "\""
comment "# Special case checking for some python 3 compatibility work"...
command
command_name
word "travis_fold"
word "start"
string
" "\""
string_content "pychecker_e"
" "\""
command
command_name
word "pychecker"
word "--quiet"
word "--limit"
number "500"
word "--only"
word "--no-shadowbuiltin"
word "--no-noeffect"
word "./tools/rdm/TestHelpers.py"
command
command_name
word "travis_fold"
word "end"
string
" "\""
string_content "pychecker_e"
" "\""
comment "# Extra special case checking for some python 3 compatibilit"...
command
command_name
word "travis_fold"
word "start"
string
" "\""
string_content "pychecker_f"
" "\""
command
command_name
word "pychecker"
word "--quiet"
word "--limit"
number "500"
word "--only"
word "--no-argsused"
word "--no-shadowbuiltin"
word "--no-noeffect"
word "./tools/rdm/ResponderTest.py"
command
command_name
word "travis_fold"
word "end"
string
" "\""
string_content "pychecker_f"
" "\""
elif_clause (+147 nodes collapsed)
else_clause (+190 nodes collapsed)
fi "fi"