java-defects4j-closure-90-functiontypebuilder

This mapping has 1 multi-map group: several pairings are equally correct there. The code view shows one arbitrary valid pairing, not the only one.

A painting is a person's account of this edit as text, recorded independently of the node mapping - a rendering often has several equally defensible answers where the mapping has one. Deletions and insertions carry no position on the opposite side in a painting, so that panel draws no caret for them.

Before…lines 1–177 unchanged (177 lines)
    // TODO(user): Doing an instanceof check here is too
    // restrictive as (Date,Error) is, for instance, an object type
    // even though its implementation is a UnionType. Would need to
    // create interfaces JSType, ObjectType, FunctionType etc and have
    // separate implementation instead of the class hierarchy, so that
    // union types can also be object types, etc.
    if (!type.isSubtype(
            typeRegistry.getNativeType(OBJECT_TYPE))) {
      reportWarning(THIS_TYPE_NON_OBJECT, type.toString());
      return false;
    }
    return true;
  }
…lines 191–728 unchanged (538 lines)

After…lines 1–177 unchanged (177 lines)
    // TODO(user): Doing an instanceof check here is too
    // restrictive as (Date,Error) is, for instance, an object type
    // even though its implementation is a UnionType. Would need to
    // create interfaces JSType, ObjectType, FunctionType etc and have
    // separate implementation instead of the class hierarchy, so that
    // union types can also be object types, etc.
    if (!type.restrictByNotNullOrUndefined().isSubtype(
            typeRegistry.getNativeType(OBJECT_TYPE))) {
      reportWarning(THIS_TYPE_NON_OBJECT, type.toString());
      return false;
    }
    return true;
  }
…lines 191–728 unchanged (538 lines)

Before…lines 1–177 unchanged (177 lines)
    // TODO(user): Doing an instanceof check here is too
    // restrictive as (Date,Error) is, for instance, an object type
    // even though its implementation is a UnionType. Would need to
    // create interfaces JSType, ObjectType, FunctionType etc and have
    // separate implementation instead of the class hierarchy, so that
    // union types can also be object types, etc.
    if (!type.isSubtype(
            typeRegistry.getNativeType(OBJECT_TYPE))) {
      reportWarning(THIS_TYPE_NON_OBJECT, type.toString());
      return false;
    }
    return true;
  }
…lines 191–728 unchanged (538 lines)

After…lines 1–177 unchanged (177 lines)
    // TODO(user): Doing an instanceof check here is too
    // restrictive as (Date,Error) is, for instance, an object type
    // even though its implementation is a UnionType. Would need to
    // create interfaces JSType, ObjectType, FunctionType etc and have
    // separate implementation instead of the class hierarchy, so that
    // union types can also be object types, etc.
    if (!type.restrictByNotNullOrUndefined().isSubtype(
            typeRegistry.getNativeType(OBJECT_TYPE))) {
      reportWarning(THIS_TYPE_NON_OBJECT, type.toString());
      return false;
    }
    return true;
  }
…lines 191–728 unchanged (538 lines)

Before

program

package_declaration

package "package"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

; ";"

import_declaration

import "import"

static "static"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

. "."

identifier "TypeCheck"

. "."

identifier "BAD_IMPLEMENTED_TYPE"

; ";"

import_declaration (+23 nodes collapsed)

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "base"

. "."

identifier "Preconditions"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "base"

. "."

identifier "Predicate"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "collect"

. "."

identifier "Iterables"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "collect"

. "."

identifier "Lists"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "collect"

. "."

identifier "Sets"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "JSDocInfo"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "JSTypeExpression"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "Node"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "Token"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "jstype"

. "."

identifier "FunctionBuilder"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "jstype"

. "."

identifier "FunctionParamBuilder"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "jstype"

. "."

identifier "FunctionType"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "jstype"

. "."

identifier "InstanceObjectType"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "jstype"

. "."

identifier "JSType"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "jstype"

. "."

identifier "JSTypeRegistry"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "jstype"

. "."

identifier "ObjectType"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "java"

. "."

identifier "util"

. "."

identifier "Iterator"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "java"

. "."

identifier "util"

. "."

identifier "List"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "java"

. "."

identifier "util"

. "."

identifier "Set"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "javax"

. "."

identifier "annotation"

. "."

identifier "Nullable"

; ";"

block_comment "/**\n * A builder for FunctionTypes, because FunctionTypes ar"...

class_declaration

modifiers

final "final"

class "class"

identifier "FunctionTypeBuilder"

class_body

{ "{"

field_declaration

modifiers

private "private"

final "final"

type_identifier "String"

variable_declarator

identifier "fnName"

; ";"

field_declaration

modifiers

private "private"

final "final"

type_identifier "AbstractCompiler"

variable_declarator

identifier "compiler"

; ";"

field_declaration

modifiers

private "private"

final "final"

type_identifier "CodingConvention"

variable_declarator

identifier "codingConvention"

; ";"

field_declaration

modifiers

private "private"

final "final"

type_identifier "JSTypeRegistry"

variable_declarator

identifier "typeRegistry"

; ";"

field_declaration

modifiers

private "private"

final "final"

type_identifier "Node"

variable_declarator

identifier "errorRoot"

; ";"

field_declaration

modifiers

private "private"

final "final"

type_identifier "String"

variable_declarator

identifier "sourceName"

; ";"

field_declaration

modifiers

private "private"

final "final"

type_identifier "Scope"

variable_declarator

identifier "scope"

; ";"

field_declaration

modifiers

private "private"

type_identifier "JSType"

variable_declarator

identifier "returnType"

= "="

null_literal "null"

; ";"

field_declaration

modifiers

private "private"

boolean_type "boolean"

variable_declarator

identifier "returnTypeInferred"

= "="

false "false"

; ";"

field_declaration

modifiers

private "private"

generic_type

type_identifier "List"

type_arguments

< "<"

type_identifier "ObjectType"

> ">"

variable_declarator

identifier "implementedInterfaces"

= "="

null_literal "null"

; ";"

field_declaration

modifiers

private "private"

type_identifier "ObjectType"

variable_declarator

identifier "baseType"

= "="

null_literal "null"

; ";"

field_declaration

modifiers

private "private"

type_identifier "ObjectType"

variable_declarator

identifier "thisType"

= "="

null_literal "null"

; ";"

field_declaration

modifiers

private "private"

boolean_type "boolean"

variable_declarator

identifier "isConstructor"

= "="

false "false"

; ";"

field_declaration

modifiers

private "private"

boolean_type "boolean"

variable_declarator

identifier "isInterface"

= "="

false "false"

; ";"

field_declaration

modifiers

private "private"

type_identifier "Node"

variable_declarator

identifier "parametersNode"

= "="

null_literal "null"

; ";"

field_declaration

modifiers

private "private"

type_identifier "Node"

variable_declarator

identifier "sourceNode"

= "="

null_literal "null"

; ";"

field_declaration

modifiers

private "private"

type_identifier "String"

variable_declarator

identifier "templateTypeName"

= "="

null_literal "null"

; ";"

field_declaration (+25 nodes collapsed)

field_declaration (+39 nodes collapsed)

field_declaration (+25 nodes collapsed)

field_declaration (+32 nodes collapsed)

class_declaration (+154 nodes collapsed)

; ";"

class_declaration (+146 nodes collapsed)

; ";"

class_declaration

modifiers

private "private"

class "class"

identifier "ThisTypeValidator"

super_interfaces

implements "implements"

type_list

generic_type

type_identifier "Predicate"

type_arguments

< "<"

type_identifier "JSType"

> ">"

class_body

{ "{"

method_declaration

modifiers

marker_annotation

@ "@"

identifier "Override"

public "public"

boolean_type "boolean"

identifier "apply"

formal_parameters

( "("

formal_parameter

type_identifier "JSType"

identifier "type"

) ")"

block

{ "{"

line_comment "// TODO(user): Doing an instanceof check here is too"

line_comment "// restrictive as (Date,Error) is, for instance, an object t"...

line_comment "// even though its implementation is a UnionType. Would need"...

line_comment "// create interfaces JSType, ObjectType, FunctionType etc an"...

line_comment "// separate implementation instead of the class hierarchy, s"...

line_comment "// union types can also be object types, etc."

if_statement

if "if"

parenthesized_expression

( "("

unary_expression

! "!"

method_invocation any 1:2

identifier "type"

. "."

identifier "isSubtype"

argument_list

( "("

method_invocation

identifier "typeRegistry"

. "."

identifier "getNativeType"

argument_list

( "("

identifier "OBJECT_TYPE"

) ")"

block (+23 nodes collapsed)

return_statement

return "return"

true "true"

; ";"

} "}"

; ";"

block_comment "/**\n * @param fnName The function name.\n * @param compil"...

constructor_declaration (+122 nodes collapsed)

block_comment "/**\n * Sets the FUNCTION node of this function.\n */"

method_declaration (+29 nodes collapsed)

block_comment "/**\n * Infer the parameter and return types of a function "...

method_declaration (+389 nodes collapsed)

block_comment "/**\n * Infer the return type from JSDocInfo.\n */"

method_declaration (+111 nodes collapsed)

block_comment "/**\n * If we haven't found a return value yet, try to look"...

method_declaration (+313 nodes collapsed)

block_comment "/**\n * Infer the role of the function (whether it's a cons"...

method_declaration (+353 nodes collapsed)

block_comment "/**\n * Infers the type of {@code this}.\n * @param type T"...

method_declaration (+72 nodes collapsed)

block_comment "/**\n * Infers the type of {@code this}.\n * @param info T"...

method_declaration (+224 nodes collapsed)

block_comment "/**\n * Infer the parameter types from the doc info alone.\n"...

method_declaration (+79 nodes collapsed)

block_comment "/**\n * Infer the parameter types from the list of argument"...

method_declaration (+529 nodes collapsed)

block_comment "/**\n * @return Whether the given param is an optional para"...

method_declaration (+88 nodes collapsed)

block_comment "/**\n * Determine whether this is a var args parameter.\n "...

method_declaration (+88 nodes collapsed)

block_comment "/**\n * Infer the template type from the doc info.\n */"

method_declaration (+54 nodes collapsed)

block_comment "/**\n * Add a parameter to the param list.\n * @param buil"...

method_declaration (+207 nodes collapsed)

block_comment "/**\n * Builds the function type, and puts it in the regist"...

method_declaration (+269 nodes collapsed)

method_declaration (+36 nodes collapsed)

block_comment "/**\n * Returns a constructor function either by returning "...

method_declaration (+260 nodes collapsed)

method_declaration (+43 nodes collapsed)

block_comment "/**\n * Determines whether the given jsdoc info declares a "...

method_declaration (+63 nodes collapsed)

} "}"

After

program

package_declaration

package "package"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

; ";"

import_declaration

import "import"

static "static"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

. "."

identifier "TypeCheck"

. "."

identifier "BAD_IMPLEMENTED_TYPE"

; ";"

import_declaration (+23 nodes collapsed)

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "base"

. "."

identifier "Preconditions"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "base"

. "."

identifier "Predicate"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "collect"

. "."

identifier "Iterables"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "collect"

. "."

identifier "Lists"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "collect"

. "."

identifier "Sets"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "JSDocInfo"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "JSTypeExpression"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "Node"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "Token"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "jstype"

. "."

identifier "FunctionBuilder"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "jstype"

. "."

identifier "FunctionParamBuilder"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "jstype"

. "."

identifier "FunctionType"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "jstype"

. "."

identifier "InstanceObjectType"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "jstype"

. "."

identifier "JSType"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "jstype"

. "."

identifier "JSTypeRegistry"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "jstype"

. "."

identifier "ObjectType"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "java"

. "."

identifier "util"

. "."

identifier "Iterator"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "java"

. "."

identifier "util"

. "."

identifier "List"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "java"

. "."

identifier "util"

. "."

identifier "Set"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "javax"

. "."

identifier "annotation"

. "."

identifier "Nullable"

; ";"

block_comment "/**\n * A builder for FunctionTypes, because FunctionTypes ar"...

class_declaration

modifiers

final "final"

class "class"

identifier "FunctionTypeBuilder"

class_body

{ "{"

field_declaration

modifiers

private "private"

final "final"

type_identifier "String"

variable_declarator

identifier "fnName"

; ";"

field_declaration

modifiers

private "private"

final "final"

type_identifier "AbstractCompiler"

variable_declarator

identifier "compiler"

; ";"

field_declaration

modifiers

private "private"

final "final"

type_identifier "CodingConvention"

variable_declarator

identifier "codingConvention"

; ";"

field_declaration

modifiers

private "private"

final "final"

type_identifier "JSTypeRegistry"

variable_declarator

identifier "typeRegistry"

; ";"

field_declaration

modifiers

private "private"

final "final"

type_identifier "Node"

variable_declarator

identifier "errorRoot"

; ";"

field_declaration

modifiers

private "private"

final "final"

type_identifier "String"

variable_declarator

identifier "sourceName"

; ";"

field_declaration

modifiers

private "private"

final "final"

type_identifier "Scope"

variable_declarator

identifier "scope"

; ";"

field_declaration

modifiers

private "private"

type_identifier "JSType"

variable_declarator

identifier "returnType"

= "="

null_literal "null"

; ";"

field_declaration

modifiers

private "private"

boolean_type "boolean"

variable_declarator

identifier "returnTypeInferred"

= "="

false "false"

; ";"

field_declaration

modifiers

private "private"

generic_type

type_identifier "List"

type_arguments

< "<"

type_identifier "ObjectType"

> ">"

variable_declarator

identifier "implementedInterfaces"

= "="

null_literal "null"

; ";"

field_declaration

modifiers

private "private"

type_identifier "ObjectType"

variable_declarator

identifier "baseType"

= "="

null_literal "null"

; ";"

field_declaration

modifiers

private "private"

type_identifier "ObjectType"

variable_declarator

identifier "thisType"

= "="

null_literal "null"

; ";"

field_declaration

modifiers

private "private"

boolean_type "boolean"

variable_declarator

identifier "isConstructor"

= "="

false "false"

; ";"

field_declaration

modifiers

private "private"

boolean_type "boolean"

variable_declarator

identifier "isInterface"

= "="

false "false"

; ";"

field_declaration

modifiers

private "private"

type_identifier "Node"

variable_declarator

identifier "parametersNode"

= "="

null_literal "null"

; ";"

field_declaration

modifiers

private "private"

type_identifier "Node"

variable_declarator

identifier "sourceNode"

= "="

null_literal "null"

; ";"

field_declaration

modifiers

private "private"

type_identifier "String"

variable_declarator

identifier "templateTypeName"

= "="

null_literal "null"

; ";"

field_declaration (+25 nodes collapsed)

field_declaration (+39 nodes collapsed)

field_declaration (+25 nodes collapsed)

field_declaration (+32 nodes collapsed)

class_declaration (+154 nodes collapsed)

; ";"

class_declaration (+146 nodes collapsed)

; ";"

class_declaration

modifiers

private "private"

class "class"

identifier "ThisTypeValidator"

super_interfaces

implements "implements"

type_list

generic_type

type_identifier "Predicate"

type_arguments

< "<"

type_identifier "JSType"

> ">"

class_body

{ "{"

method_declaration

modifiers

marker_annotation

@ "@"

identifier "Override"

public "public"

boolean_type "boolean"

identifier "apply"

formal_parameters

( "("

formal_parameter

type_identifier "JSType"

identifier "type"

) ")"

block

{ "{"

line_comment "// TODO(user): Doing an instanceof check here is too"

line_comment "// restrictive as (Date,Error) is, for instance, an object t"...

line_comment "// even though its implementation is a UnionType. Would need"...

line_comment "// create interfaces JSType, ObjectType, FunctionType etc an"...

line_comment "// separate implementation instead of the class hierarchy, s"...

line_comment "// union types can also be object types, etc."

if_statement

if "if"

parenthesized_expression

( "("

unary_expression

! "!"

method_invocation any 1:2

identifier "type"

. "."

identifier "restrictByNotNullOrUndefined"

argument_list

( "("

) ")"

. "."

identifier "isSubtype"

argument_list

( "("

method_invocation

identifier "typeRegistry"

. "."

identifier "getNativeType"

argument_list

( "("

identifier "OBJECT_TYPE"

) ")"

block (+23 nodes collapsed)

return_statement

return "return"

true "true"

; ";"

} "}"

; ";"

block_comment "/**\n * @param fnName The function name.\n * @param compil"...

constructor_declaration (+122 nodes collapsed)

block_comment "/**\n * Sets the FUNCTION node of this function.\n */"

method_declaration (+29 nodes collapsed)

block_comment "/**\n * Infer the parameter and return types of a function "...

method_declaration (+389 nodes collapsed)

block_comment "/**\n * Infer the return type from JSDocInfo.\n */"

method_declaration (+111 nodes collapsed)

block_comment "/**\n * If we haven't found a return value yet, try to look"...

method_declaration (+313 nodes collapsed)

block_comment "/**\n * Infer the role of the function (whether it's a cons"...

method_declaration (+353 nodes collapsed)

block_comment "/**\n * Infers the type of {@code this}.\n * @param type T"...

method_declaration (+72 nodes collapsed)

block_comment "/**\n * Infers the type of {@code this}.\n * @param info T"...

method_declaration (+224 nodes collapsed)

block_comment "/**\n * Infer the parameter types from the doc info alone.\n"...

method_declaration (+79 nodes collapsed)

block_comment "/**\n * Infer the parameter types from the list of argument"...

method_declaration (+529 nodes collapsed)

block_comment "/**\n * @return Whether the given param is an optional para"...

method_declaration (+88 nodes collapsed)

block_comment "/**\n * Determine whether this is a var args parameter.\n "...

method_declaration (+88 nodes collapsed)

block_comment "/**\n * Infer the template type from the doc info.\n */"

method_declaration (+54 nodes collapsed)

block_comment "/**\n * Add a parameter to the param list.\n * @param buil"...

method_declaration (+207 nodes collapsed)

block_comment "/**\n * Builds the function type, and puts it in the regist"...

method_declaration (+269 nodes collapsed)

method_declaration (+36 nodes collapsed)

block_comment "/**\n * Returns a constructor function either by returning "...

method_declaration (+260 nodes collapsed)

method_declaration (+43 nodes collapsed)

block_comment "/**\n * Determines whether the given jsdoc info declares a "...

method_declaration (+63 nodes collapsed)

} "}"