java-defects4j-closure-165-recordtypebuilder

A painting is a person's account of this edit as text, recorded independently of the node mapping - a rendering often has several equally defensible answers where the mapping has one. Deletions and insertions carry no position on the opposite side in a painting, so that panel draws no caret for them.

Before…lines 1–47 unchanged (47 lines)
48/**
* A builder for record types.
*
*/
52public class RecordTypeBuilder {
private boolean isEmpty = true;
private final JSTypeRegistry registry;
private final HashMap<String, RecordProperty> properties = Maps.newHashMap();
56
public RecordTypeBuilder(JSTypeRegistry registry) {
  this.registry = registry;
}
60
/** See the comments on RecordType about synthetic types. */
62
/**
 * Adds a property with the given name and type to the record type.
 * @param name the name of the new property
 * @param type the JSType of the new property
 * @param propertyNode the node that holds this property definition
 * @return The builder itself for chaining purposes, or null if there's
…lines 69–85 unchanged (17 lines)
   // If we have an empty record, simply return the object type.
  if (isEmpty) {
     return registry.getNativeObjectType(JSTypeNative.OBJECT_TYPE);
  }
90
  return new RecordType(
      registry, Collections.unmodifiableMap(properties));
}
94
static class RecordProperty {
  private final JSType type;
  private final Node propertyNode;
98
…lines 99–113 unchanged (15 lines)

After…lines 1–47 unchanged (47 lines)
48/**
* A builder for record types.
*
*/
52public class RecordTypeBuilder {
private boolean isEmpty = true;
private boolean isDeclared = true;
private final JSTypeRegistry registry;
private final HashMap<String, RecordProperty> properties = Maps.newHashMap();
57
public RecordTypeBuilder(JSTypeRegistry registry) {
  this.registry = registry;
}
61
/** See the comments on RecordType about synthetic types. */
void setSynthesized(boolean synthesized) {
  isDeclared = !synthesized;
}
66
/**
 * Adds a property with the given name and type to the record type.
 * @param name the name of the new property
 * @param type the JSType of the new property
 * @param propertyNode the node that holds this property definition
…lines 72–89 unchanged (18 lines)
   // If we have an empty record, simply return the object type.
  if (isEmpty) {
     return registry.getNativeObjectType(JSTypeNative.OBJECT_TYPE);
  }
94
  return new RecordType(
      registry, Collections.unmodifiableMap(properties), isDeclared);
}
98
static class RecordProperty {
  private final JSType type;
  private final Node propertyNode;
102
…lines 103–117 unchanged (15 lines)

Before…lines 1–47 unchanged (47 lines)
48/**
* A builder for record types.
*
*/
52public class RecordTypeBuilder {
private boolean isEmpty = true;
private final JSTypeRegistry registry;
private final HashMap<String, RecordProperty> properties = Maps.newHashMap();
56
public RecordTypeBuilder(JSTypeRegistry registry) {
  this.registry = registry;
}
60
/** See the comments on RecordType about synthetic types. */
62
/**
 * Adds a property with the given name and type to the record type.
 * @param name the name of the new property
 * @param type the JSType of the new property
 * @param propertyNode the node that holds this property definition
 * @return The builder itself for chaining purposes, or null if there's
…lines 69–85 unchanged (17 lines)
   // If we have an empty record, simply return the object type.
  if (isEmpty) {
     return registry.getNativeObjectType(JSTypeNative.OBJECT_TYPE);
  }
90
  return new RecordType(
      registry, Collections.unmodifiableMap(properties));
}
94
static class RecordProperty {
  private final JSType type;
  private final Node propertyNode;
98
…lines 99–113 unchanged (15 lines)

After…lines 1–47 unchanged (47 lines)
48/**
* A builder for record types.
*
*/
52public class RecordTypeBuilder {
private boolean isEmpty = true;
private boolean isDeclared = true;
private final JSTypeRegistry registry;
private final HashMap<String, RecordProperty> properties = Maps.newHashMap();
57
public RecordTypeBuilder(JSTypeRegistry registry) {
  this.registry = registry;
}
61
/** See the comments on RecordType about synthetic types. */
void setSynthesized(boolean synthesized) {
  isDeclared = !synthesized;
}
66
/**
 * Adds a property with the given name and type to the record type.
 * @param name the name of the new property
 * @param type the JSType of the new property
 * @param propertyNode the node that holds this property definition
…lines 72–89 unchanged (18 lines)
   // If we have an empty record, simply return the object type.
  if (isEmpty) {
     return registry.getNativeObjectType(JSTypeNative.OBJECT_TYPE);
  }
94
  return new RecordType(
      registry, Collections.unmodifiableMap(properties), isDeclared);
}
98
static class RecordProperty {
  private final JSType type;
  private final Node propertyNode;
102
…lines 103–117 unchanged (15 lines)

Before…lines 1–47 unchanged (47 lines)
48/**
* A builder for record types.
*
*/
52public class RecordTypeBuilder {
private boolean isEmpty = true;
private final JSTypeRegistry registry;
private final HashMap<String, RecordProperty> properties = Maps.newHashMap();
56
public RecordTypeBuilder(JSTypeRegistry registry) {
  this.registry = registry;
}
60
/** See the comments on RecordType about synthetic types. */
62
/**
 * Adds a property with the given name and type to the record type.
 * @param name the name of the new property
 * @param type the JSType of the new property
 * @param propertyNode the node that holds this property definition
 * @return The builder itself for chaining purposes, or null if there's
…lines 69–85 unchanged (17 lines)
   // If we have an empty record, simply return the object type.
  if (isEmpty) {
     return registry.getNativeObjectType(JSTypeNative.OBJECT_TYPE);
  }
90
  return new RecordType(
      registry, Collections.unmodifiableMap(properties));
}
94
static class RecordProperty {
  private final JSType type;
  private final Node propertyNode;
98
…lines 99–113 unchanged (15 lines)

After…lines 1–47 unchanged (47 lines)
48/**
* A builder for record types.
*
*/
52public class RecordTypeBuilder {
private boolean isEmpty = true;
private boolean isDeclared = true;
private final JSTypeRegistry registry;
private final HashMap<String, RecordProperty> properties = Maps.newHashMap();
57
public RecordTypeBuilder(JSTypeRegistry registry) {
  this.registry = registry;
}
61
/** See the comments on RecordType about synthetic types. */
void setSynthesized(boolean synthesized) {
  isDeclared = !synthesized;
}
66
/**
 * Adds a property with the given name and type to the record type.
 * @param name the name of the new property
 * @param type the JSType of the new property
 * @param propertyNode the node that holds this property definition
…lines 72–89 unchanged (18 lines)
   // If we have an empty record, simply return the object type.
  if (isEmpty) {
     return registry.getNativeObjectType(JSTypeNative.OBJECT_TYPE);
  }
94
  return new RecordType(
      registry, Collections.unmodifiableMap(properties), isDeclared);
}
98
static class RecordProperty {
  private final JSType type;
  private final Node propertyNode;
102
…lines 103–117 unchanged (15 lines)

Before

program

block_comment "/*\n *\n * ***** BEGIN LICENSE BLOCK *****\n * Version: MPL 1.1"...

package_declaration

package "package"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "jstype"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "collect"

. "."

identifier "Maps"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "Node"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "java"

. "."

identifier "util"

. "."

identifier "Collections"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "java"

. "."

identifier "util"

. "."

identifier "HashMap"

; ";"

block_comment "/**\n * A builder for record types.\n *\n */"

class_declaration

modifiers

public "public"

class "class"

identifier "RecordTypeBuilder"

class_body

{ "{"

field_declaration

modifiers

private "private"

boolean_type "boolean"

variable_declarator

identifier "isEmpty"

= "="

true "true"

; ";"

field_declaration

modifiers

private "private"

final "final"

type_identifier "JSTypeRegistry"

variable_declarator

identifier "registry"

; ";"

field_declaration (+23 nodes collapsed)

constructor_declaration (+22 nodes collapsed)

block_comment "/** See the comments on RecordType about synthetic types. */"

block_comment "/**\n * Adds a property with the given name and type to the"...

method_declaration (+72 nodes collapsed)

block_comment "/**\n * Creates a record.\n * @return The record type.\n "...

method_declaration

modifiers

public "public"

type_identifier "JSType"

identifier "build"

formal_parameters

( "("

) ")"

block

{ "{"

line_comment "// If we have an empty record, simply return the object type"...

if_statement (+23 nodes collapsed)

return_statement

return "return"

object_creation_expression

new "new"

type_identifier "RecordType"

argument_list

( "("

identifier "registry"

, ","

method_invocation

identifier "Collections"

. "."

identifier "unmodifiableMap"

argument_list

( "("

identifier "properties"

) ")"

; ";"

} "}"

class_declaration (+87 nodes collapsed)

} "}"

After

program

block_comment "/*\n *\n * ***** BEGIN LICENSE BLOCK *****\n * Version: MPL 1.1"...

package_declaration

package "package"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "jstype"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "collect"

. "."

identifier "Maps"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "Node"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "java"

. "."

identifier "util"

. "."

identifier "Collections"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "java"

. "."

identifier "util"

. "."

identifier "HashMap"

; ";"

block_comment "/**\n * A builder for record types.\n *\n */"

class_declaration

modifiers

public "public"

class "class"

identifier "RecordTypeBuilder"

class_body

{ "{"

field_declaration

modifiers

private "private"

boolean_type "boolean"

variable_declarator

identifier "isEmpty"

= "="

true "true"

; ";"

field_declaration

modifiers

private "private"

boolean_type "boolean"

variable_declarator

identifier "isDeclared"

= "="

true "true"

; ";"

field_declaration

modifiers

private "private"

final "final"

type_identifier "JSTypeRegistry"

variable_declarator

identifier "registry"

; ";"

field_declaration (+23 nodes collapsed)

constructor_declaration (+22 nodes collapsed)

block_comment "/** See the comments on RecordType about synthetic types. */"

method_declaration

void_type "void"

identifier "setSynthesized"

formal_parameters

( "("

formal_parameter

boolean_type "boolean"

identifier "synthesized"

) ")"

block

{ "{"

expression_statement

assignment_expression

identifier "isDeclared"

= "="

unary_expression

! "!"

identifier "synthesized"

; ";"

} "}"

block_comment "/**\n * Adds a property with the given name and type to the"...

method_declaration (+72 nodes collapsed)

block_comment "/**\n * Creates a record.\n * @return The record type.\n "...

method_declaration

modifiers

public "public"

type_identifier "JSType"

identifier "build"

formal_parameters

( "("

) ")"

block

{ "{"

line_comment "// If we have an empty record, simply return the object type"...

if_statement (+23 nodes collapsed)

return_statement

return "return"

object_creation_expression

new "new"

type_identifier "RecordType"

argument_list

( "("

identifier "registry"

, ","

method_invocation

identifier "Collections"

. "."

identifier "unmodifiableMap"

argument_list

( "("

identifier "properties"

) ")"

, ","

identifier "isDeclared"

) ")"

; ";"

} "}"

class_declaration (+87 nodes collapsed)

} "}"