java-defects4j-closure-16-scopedaliases

A painting is a person's account of this edit as text, recorded independently of the node mapping - a rendering often has several equally defensible answers where the mapping has one. Deletions and insertions carry no position on the opposite side in a painting, so that panel draws no caret for them.

Before

program

package_declaration

package "package"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "base"

. "."

identifier "Preconditions"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "collect"

. "."

identifier "Lists"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "collect"

. "."

identifier "Maps"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "collect"

. "."

identifier "Sets"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

. "."

identifier "CompilerOptions"

. "."

identifier "AliasTransformation"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

. "."

identifier "CompilerOptions"

. "."

identifier "AliasTransformationHandler"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

. "."

identifier "Scope"

. "."

identifier "Var"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "JSDocInfo"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "Node"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "SourcePosition"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "Token"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "java"

. "."

identifier "util"

. "."

identifier "Collection"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "java"

. "."

identifier "util"

. "."

identifier "List"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "java"

. "."

identifier "util"

. "."

identifier "Map"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "java"

. "."

identifier "util"

. "."

identifier "Set"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "javax"

. "."

identifier "annotation"

. "."

identifier "Nullable"

; ";"

block_comment "/**\n * Process aliases in goog.scope blocks.\n *\n * goog.scop"...

class_declaration

class "class"

identifier "ScopedAliases"

super_interfaces

implements "implements"

type_list

type_identifier "HotSwapCompilerPass"

class_body

{ "{"

block_comment "/** Name used to denote an scoped function block used for al"...

field_declaration

modifiers

static "static"

final "final"

type_identifier "String"

variable_declarator

identifier "SCOPING_METHOD_NAME"

= "="

string_literal

" "\""

string_fragment "goog.scope"

" "\""

; ";"

field_declaration

modifiers

private "private"

final "final"

type_identifier "AbstractCompiler"

variable_declarator

identifier "compiler"

; ";"

field_declaration

modifiers

private "private"

final "final"

type_identifier "PreprocessorSymbolTable"

variable_declarator

identifier "preprocessorSymbolTable"

; ";"

field_declaration

modifiers

private "private"

final "final"

type_identifier "AliasTransformationHandler"

variable_declarator

identifier "transformationHandler"

; ";"

line_comment "// Errors"

field_declaration (+25 nodes collapsed)

field_declaration (+31 nodes collapsed)

field_declaration (+25 nodes collapsed)

constructor_declaration (+50 nodes collapsed)

method_declaration (+31 nodes collapsed)

method_declaration (+329 nodes collapsed)

interface_declaration

modifiers

private "private"

interface "interface"

identifier "AliasUsage"

interface_body

{ "{"

method_declaration

modifiers

public "public"

void_type "void"

identifier "applyAlias"

formal_parameters

( "("

) ")"

; ";"

} "}"

class_declaration (+99 nodes collapsed)

class_declaration

modifiers

private "private"

class "class"

identifier "AliasedTypeNode"

super_interfaces

implements "implements"

type_list

type_identifier "AliasUsage"

class_body

{ "{"

field_declaration

modifiers

private "private"

final "final"

type_identifier "Node"

variable_declarator

identifier "typeReference"

; ";"

field_declaration

modifiers

private "private"

final "final"

type_identifier "String"

variable_declarator

identifier "aliasName"

; ";"

constructor_declaration

identifier "AliasedTypeNode"

formal_parameters

( "("

formal_parameter

type_identifier "Node"

identifier "typeReference"

, ","

formal_parameter

type_identifier "String"

identifier "aliasName"

) ")"

constructor_body

{ "{"

expression_statement

assignment_expression

field_access

this "this"

. "."

identifier "typeReference"

= "="

identifier "typeReference"

; ";"

expression_statement

assignment_expression

field_access

this "this"

. "."

identifier "aliasName"

= "="

identifier "aliasName"

; ";"

} "}"

method_declaration

modifiers

marker_annotation

@ "@"

identifier "Override"

public "public"

void_type "void"

identifier "applyAlias"

formal_parameters

( "("

) ")"

block

{ "{"

expression_statement

method_invocation

identifier "typeReference"

. "."

identifier "setString"

argument_list

( "("

identifier "aliasName"

) ")"

; ";"

} "}"

class_declaration

modifiers

private "private"

class "class"

identifier "Traversal"

super_interfaces

implements "implements"

type_list

scoped_type_identifier

type_identifier "NodeTraversal"

. "."

type_identifier "ScopedCallback"

class_body

{ "{"

line_comment "// The job of this class is to collect these three data sets"...

line_comment "// The order of this list determines the order that aliases "...

field_declaration (+21 nodes collapsed)

line_comment "// This map is temporary and cleared for each scope."

field_declaration (+23 nodes collapsed)

line_comment "// Suppose you create an alias."

line_comment "// var x = goog.x;"

line_comment "// As a side-effect, this means you can shadow the namespace"...

line_comment "// in inner scopes. When we inline the namespaces, we have t"...

line_comment "// these shadows."

line_comment "//"

line_comment "// Fortunately, we already have a name uniquifier that runs "...

line_comment "// normalization (before optimizations). We run it here on a"...

line_comment "// set of variables, but only as a last resort (because this"...

line_comment "// up warning messages downstream)."

field_declaration (+21 nodes collapsed)

field_declaration

modifiers

private "private"

boolean_type "boolean"

variable_declarator

identifier "hasNamespaceShadows"

= "="

false "false"

; ";"

field_declaration

modifiers

private "private"

boolean_type "boolean"

variable_declarator

identifier "hasErrors"

= "="

false "false"

; ";"

field_declaration

modifiers

private "private"

type_identifier "AliasTransformation"

variable_declarator

identifier "transformation"

= "="

null_literal "null"

; ";"

method_declaration

generic_type

type_identifier "Collection"

type_arguments

< "<"

type_identifier "Node"

> ">"

identifier "getAliasDefinitionsInOrder"

formal_parameters

( "("

) ")"

block

{ "{"

return_statement

return "return"

identifier "aliasDefinitionsInOrder"

; ";"

} "}"

method_declaration

modifiers

private "private"

generic_type

type_identifier "List"

type_arguments

< "<"

type_identifier "AliasUsage"

> ">"

identifier "getAliasUsages"

formal_parameters

( "("

) ")"

block

{ "{"

return_statement

return "return"

identifier "aliasUsages"

; ";"

} "}"

method_declaration

generic_type

type_identifier "List"

type_arguments

< "<"

type_identifier "Node"

> ">"

identifier "getScopeCalls"

formal_parameters

( "("

) ")"

block

{ "{"

return_statement

return "return"

identifier "scopeCalls"

; ";"

} "}"

method_declaration

boolean_type "boolean"

identifier "hasErrors"

formal_parameters

( "("

) ")"

block

{ "{"

return_statement

return "return"

identifier "hasErrors"

; ";"

} "}"

method_declaration (+46 nodes collapsed)

method_declaration (+90 nodes collapsed)

method_declaration (+99 nodes collapsed)

method_declaration (+81 nodes collapsed)

method_declaration (+186 nodes collapsed)

method_declaration (+55 nodes collapsed)

method_declaration (+336 nodes collapsed)

block_comment "/** Find out if there are any local shadows of namespaces. *"...

method_declaration (+87 nodes collapsed)

block_comment "/**\n * Rename any local shadows of namespaces.\n * Th"...

method_declaration (+106 nodes collapsed)

method_declaration (+201 nodes collapsed)

method_declaration (+485 nodes collapsed)

method_declaration

modifiers

private "private"

void_type "void"

identifier "fixTypeNode"

formal_parameters

( "("

formal_parameter

type_identifier "Node"

identifier "typeNode"

) ")"

block

{ "{"

if_statement

if "if"

parenthesized_expression

( "("

method_invocation

identifier "typeNode"

. "."

identifier "isString"

argument_list

( "("

) ")"

block

{ "{"

local_variable_declaration

type_identifier "String"

variable_declarator

identifier "name"

= "="

method_invocation

identifier "typeNode"

. "."

identifier "getString"

argument_list

( "("

) ")"

; ";"

local_variable_declaration

integral_type

int "int"

variable_declarator

identifier "endIndex"

= "="

method_invocation

identifier "name"

. "."

identifier "indexOf"

argument_list

( "("

character_literal "'.'"

) ")"

; ";"

if_statement (+26 nodes collapsed)

local_variable_declaration

type_identifier "String"

variable_declarator

identifier "baseName"

= "="

method_invocation

identifier "name"

. "."

identifier "substring"

argument_list

( "("

decimal_integer_literal "0"

, ","

identifier "endIndex"

) ")"

; ";"

local_variable_declaration

type_identifier "Var"

variable_declarator

identifier "aliasVar"

= "="

method_invocation

identifier "aliases"

. "."

identifier "get"

argument_list

( "("

identifier "baseName"

) ")"

; ";"

if_statement

if "if"

parenthesized_expression

( "("

binary_expression

identifier "aliasVar"

!= "!="

null_literal "null"

) ")"

block

{ "{"

local_variable_declaration

type_identifier "Node"

variable_declarator

identifier "aliasedNode"

= "="

method_invocation

identifier "aliasVar"

. "."

identifier "getInitialValue"

argument_list

( "("

) ")"

; ";"

expression_statement

method_invocation

identifier "aliasUsages"

. "."

identifier "add"

argument_list

( "("

object_creation_expression

new "new"

type_identifier "AliasedTypeNode"

argument_list

( "("

identifier "typeNode"

, ","

binary_expression

method_invocation

identifier "aliasedNode"

. "."

identifier "getQualifiedName"

argument_list

( "("

) ")"

+ "+"

method_invocation

identifier "name"

. "."

identifier "substring"

argument_list

( "("

identifier "endIndex"

) ")"

; ";"

} "}"

for_statement (+43 nodes collapsed)

} "}"

After

program

package_declaration

package "package"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "base"

. "."

identifier "Preconditions"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "collect"

. "."

identifier "Lists"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "collect"

. "."

identifier "Maps"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "collect"

. "."

identifier "Sets"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

. "."

identifier "CompilerOptions"

. "."

identifier "AliasTransformation"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

. "."

identifier "CompilerOptions"

. "."

identifier "AliasTransformationHandler"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

. "."

identifier "Scope"

. "."

identifier "Var"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "JSDocInfo"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "Node"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "SourcePosition"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "Token"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "java"

. "."

identifier "util"

. "."

identifier "Collection"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "java"

. "."

identifier "util"

. "."

identifier "List"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "java"

. "."

identifier "util"

. "."

identifier "Map"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "java"

. "."

identifier "util"

. "."

identifier "Set"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "javax"

. "."

identifier "annotation"

. "."

identifier "Nullable"

; ";"

block_comment "/**\n * Process aliases in goog.scope blocks.\n *\n * goog.scop"...

class_declaration

class "class"

identifier "ScopedAliases"

super_interfaces

implements "implements"

type_list

type_identifier "HotSwapCompilerPass"

class_body

{ "{"

block_comment "/** Name used to denote an scoped function block used for al"...

field_declaration

modifiers

static "static"

final "final"

type_identifier "String"

variable_declarator

identifier "SCOPING_METHOD_NAME"

= "="

string_literal

" "\""

string_fragment "goog.scope"

" "\""

; ";"

field_declaration

modifiers

private "private"

final "final"

type_identifier "AbstractCompiler"

variable_declarator

identifier "compiler"

; ";"

field_declaration

modifiers

private "private"

final "final"

type_identifier "PreprocessorSymbolTable"

variable_declarator

identifier "preprocessorSymbolTable"

; ";"

field_declaration

modifiers

private "private"

final "final"

type_identifier "AliasTransformationHandler"

variable_declarator

identifier "transformationHandler"

; ";"

line_comment "// Errors"

field_declaration (+25 nodes collapsed)

field_declaration (+31 nodes collapsed)

field_declaration (+25 nodes collapsed)

constructor_declaration (+50 nodes collapsed)

method_declaration (+31 nodes collapsed)

method_declaration (+329 nodes collapsed)

interface_declaration

modifiers

private "private"

interface "interface"

identifier "AliasUsage"

interface_body

{ "{"

method_declaration

modifiers

public "public"

void_type "void"

identifier "applyAlias"

formal_parameters

( "("

) ")"

; ";"

} "}"

class_declaration (+99 nodes collapsed)

class_declaration

modifiers

private "private"

class "class"

identifier "AliasedTypeNode"

super_interfaces

implements "implements"

type_list

type_identifier "AliasUsage"

class_body

{ "{"

field_declaration

modifiers

private "private"

final "final"

type_identifier "Node"

variable_declarator

identifier "typeReference"

; ";"

field_declaration

modifiers

private "private"

final "final"

type_identifier "Node"

variable_declarator

identifier "aliasDefinition"

; ";"

field_declaration

modifiers

private "private"

final "final"

type_identifier "String"

variable_declarator

identifier "aliasName"

; ";"

constructor_declaration

identifier "AliasedTypeNode"

formal_parameters

( "("

formal_parameter

type_identifier "Node"

identifier "typeReference"

, ","

formal_parameter

type_identifier "Node"

identifier "aliasDefinition"

, ","

formal_parameter

type_identifier "String"

identifier "aliasName"

) ")"

constructor_body

{ "{"

expression_statement

assignment_expression

field_access

this "this"

. "."

identifier "typeReference"

= "="

identifier "typeReference"

; ";"

expression_statement

assignment_expression

field_access

this "this"

. "."

identifier "aliasDefinition"

= "="

identifier "aliasDefinition"

; ";"

expression_statement

assignment_expression

field_access

this "this"

. "."

identifier "aliasName"

= "="

identifier "aliasName"

; ";"

} "}"

method_declaration

modifiers

marker_annotation

@ "@"

identifier "Override"

public "public"

void_type "void"

identifier "applyAlias"

formal_parameters

( "("

) ")"

block

{ "{"

local_variable_declaration

type_identifier "String"

variable_declarator

identifier "typeName"

= "="

method_invocation

identifier "typeReference"

. "."

identifier "getString"

argument_list

( "("

) ")"

; ";"

local_variable_declaration

type_identifier "String"

variable_declarator

identifier "aliasExpanded"

= "="

method_invocation

identifier "Preconditions"

. "."

identifier "checkNotNull"

argument_list

( "("

method_invocation

identifier "aliasDefinition"

. "."

identifier "getQualifiedName"

argument_list

( "("

) ")"

; ";"

expression_statement

method_invocation

identifier "Preconditions"

. "."

identifier "checkState"

argument_list

( "("

method_invocation

identifier "typeName"

. "."

identifier "startsWith"

argument_list

( "("

identifier "aliasName"

) ")"

; ";"

expression_statement

method_invocation

identifier "typeReference"

. "."

identifier "setString"

argument_list

( "("

method_invocation

identifier "typeName"

. "."

identifier "replaceFirst"

argument_list

( "("

identifier "aliasName"

, ","

identifier "aliasExpanded"

) ")"

; ";"

} "}"

class_declaration

modifiers

private "private"

class "class"

identifier "Traversal"

super_interfaces

implements "implements"

type_list

scoped_type_identifier

type_identifier "NodeTraversal"

. "."

type_identifier "ScopedCallback"

class_body

{ "{"

line_comment "// The job of this class is to collect these three data sets"...

line_comment "// The order of this list determines the order that aliases "...

field_declaration (+21 nodes collapsed)

line_comment "// This map is temporary and cleared for each scope."

field_declaration (+23 nodes collapsed)

line_comment "// Suppose you create an alias."

line_comment "// var x = goog.x;"

line_comment "// As a side-effect, this means you can shadow the namespace"...

line_comment "// in inner scopes. When we inline the namespaces, we have t"...

line_comment "// these shadows."

line_comment "//"

line_comment "// Fortunately, we already have a name uniquifier that runs "...

line_comment "// normalization (before optimizations). We run it here on a"...

line_comment "// set of variables, but only as a last resort (because this"...

line_comment "// up warning messages downstream)."

field_declaration (+21 nodes collapsed)

field_declaration

modifiers

private "private"

boolean_type "boolean"

variable_declarator

identifier "hasNamespaceShadows"

= "="

false "false"

; ";"

field_declaration

modifiers

private "private"

boolean_type "boolean"

variable_declarator

identifier "hasErrors"

= "="

false "false"

; ";"

field_declaration

modifiers

private "private"

type_identifier "AliasTransformation"

variable_declarator

identifier "transformation"

= "="

null_literal "null"

; ";"

method_declaration

generic_type

type_identifier "Collection"

type_arguments

< "<"

type_identifier "Node"

> ">"

identifier "getAliasDefinitionsInOrder"

formal_parameters

( "("

) ")"

block

{ "{"

return_statement

return "return"

identifier "aliasDefinitionsInOrder"

; ";"

} "}"

method_declaration

modifiers

private "private"

generic_type

type_identifier "List"

type_arguments

< "<"

type_identifier "AliasUsage"

> ">"

identifier "getAliasUsages"

formal_parameters

( "("

) ")"

block

{ "{"

return_statement

return "return"

identifier "aliasUsages"

; ";"

} "}"

method_declaration

generic_type

type_identifier "List"

type_arguments

< "<"

type_identifier "Node"

> ">"

identifier "getScopeCalls"

formal_parameters

( "("

) ")"

block

{ "{"

return_statement

return "return"

identifier "scopeCalls"

; ";"

} "}"

method_declaration

boolean_type "boolean"

identifier "hasErrors"

formal_parameters

( "("

) ")"

block

{ "{"

return_statement

return "return"

identifier "hasErrors"

; ";"

} "}"

method_declaration (+46 nodes collapsed)

method_declaration (+90 nodes collapsed)

method_declaration (+99 nodes collapsed)

method_declaration (+81 nodes collapsed)

method_declaration (+186 nodes collapsed)

method_declaration (+55 nodes collapsed)

method_declaration (+336 nodes collapsed)

block_comment "/** Find out if there are any local shadows of namespaces. *"...

method_declaration (+87 nodes collapsed)

block_comment "/**\n * Rename any local shadows of namespaces.\n * Th"...

method_declaration (+106 nodes collapsed)

method_declaration (+201 nodes collapsed)

method_declaration (+485 nodes collapsed)

method_declaration

modifiers

private "private"

void_type "void"

identifier "fixTypeNode"

formal_parameters

( "("

formal_parameter

type_identifier "Node"

identifier "typeNode"

) ")"

block

{ "{"

if_statement

if "if"

parenthesized_expression

( "("

method_invocation

identifier "typeNode"

. "."

identifier "isString"

argument_list

( "("

) ")"

block

{ "{"

local_variable_declaration

type_identifier "String"

variable_declarator

identifier "name"

= "="

method_invocation

identifier "typeNode"

. "."

identifier "getString"

argument_list

( "("

) ")"

; ";"

local_variable_declaration

integral_type

int "int"

variable_declarator

identifier "endIndex"

= "="

method_invocation

identifier "name"

. "."

identifier "indexOf"

argument_list

( "("

character_literal "'.'"

) ")"

; ";"

if_statement (+26 nodes collapsed)

local_variable_declaration

type_identifier "String"

variable_declarator

identifier "baseName"

= "="

method_invocation

identifier "name"

. "."

identifier "substring"

argument_list

( "("

decimal_integer_literal "0"

, ","

identifier "endIndex"

) ")"

; ";"

local_variable_declaration

type_identifier "Var"

variable_declarator

identifier "aliasVar"

= "="

method_invocation

identifier "aliases"

. "."

identifier "get"

argument_list

( "("

identifier "baseName"

) ")"

; ";"

if_statement

if "if"

parenthesized_expression

( "("

binary_expression

identifier "aliasVar"

!= "!="

null_literal "null"

) ")"

block

{ "{"

local_variable_declaration

type_identifier "Node"

variable_declarator

identifier "aliasedNode"

= "="

method_invocation

identifier "aliasVar"

. "."

identifier "getInitialValue"

argument_list

( "("

) ")"

; ";"

expression_statement

method_invocation

identifier "aliasUsages"

. "."

identifier "add"

argument_list

( "("

object_creation_expression

new "new"

type_identifier "AliasedTypeNode"

argument_list

( "("

identifier "typeNode"

, ","

identifier "aliasedNode"

, ","

identifier "baseName"

) ")"

; ";"

} "}"

for_statement (+43 nodes collapsed)

} "}"