java-defects4j-closure-155-inlinevariables

This mapping has 1 multi-map group: several pairings are equally correct there. The code view shows one arbitrary valid pairing, not the only one.

A painting is a person's account of this edit as text, recorded independently of the node mapping - a rendering often has several equally defensible answers where the mapping has one. Deletions and insertions carry no position on the opposite side in a painting, so that panel draws no caret for them.

Before…lines 1–191 unchanged (191 lines)
  /**
   * For all variables in this scope, see if they are only used once.
   * If it looks safe to do so, inline them.
   */
  private void doInlinesForScope(NodeTraversal t,
      Map<Var, ReferenceCollection> referenceMap) {
198
    for (Iterator<Var> it = t.getScope().getVars(); it.hasNext();) {
      Var v = it.next();
201
      ReferenceCollection referenceInfo = referenceMap.get(v);
203
      // referenceInfo will be null if we're in constants-only mode
…lines 205–213 unchanged (9 lines)
        staleVars.add(v);
      } else if (mode == Mode.CONSTANTS_ONLY) {
        // If we're in constants-only mode, don't run more aggressive
        // inlining heuristics. See InlineConstantsTest.
        continue;
      } else {
        inlineNonConstants(v, referenceInfo);
      }
    }
  }
224
          // Any reference that is not a read of the arguments property
          // consider a escape of the arguments object.
227
228
  private void inlineNonConstants(
      Var v, ReferenceCollection referenceInfo) {
    int refCount = referenceInfo.references.size();
    Reference declaration = referenceInfo.references.get(0);
    Reference init = referenceInfo.getInitializingReference();
    int firstRefAfterInit = (declaration == init) ? 2 : 3;
235
    if (refCount > 1 &&
…lines 237–269 unchanged (33 lines)
270
    // If this variable was not inlined normally, check if we can
    // inline an alias of it. (If the variable was inlined, then the
    // reference data is out of sync. We're better off just waiting for
    // the next pass.)
    if (
        !staleVars.contains(v) && referenceInfo.isWellDefined() &&
        referenceInfo.isAssignedOnceInLifetime()) {
      List<Reference> refs = referenceInfo.references;
      for (int i = 1 /* start from a read */; i < refs.size(); i++) {
        Node nameNode = refs.get(i).getNameNode();
        if (aliasCandidates.containsKey(nameNode)) {
          AliasCandidate candidate = aliasCandidates.get(nameNode);
…lines 283–694 unchanged (412 lines)

After…lines 1–192 unchanged (192 lines)
   * For all variables in this scope, see if they are only used once.
   * If it looks safe to do so, inline them.
   */
  private void doInlinesForScope(NodeTraversal t,
      Map<Var, ReferenceCollection> referenceMap) {
198
    boolean maybeModifiedArguments =
        maybeEscapedOrModifiedArguments(t.getScope(), referenceMap);
    for (Iterator<Var> it = t.getScope().getVars(); it.hasNext();) {
      Var v = it.next();
203
      ReferenceCollection referenceInfo = referenceMap.get(v);
205
      // referenceInfo will be null if we're in constants-only mode
…lines 207–215 unchanged (9 lines)
        staleVars.add(v);
      } else if (mode == Mode.CONSTANTS_ONLY) {
        // If we're in constants-only mode, don't run more aggressive
        // inlining heuristics. See InlineConstantsTest.
        continue;
      } else {
        inlineNonConstants(v, referenceInfo, maybeModifiedArguments);
      }
    }
  }
226
  private boolean maybeEscapedOrModifiedArguments(
      Scope scope, Map<Var, ReferenceCollection> referenceMap) {
    if (scope.isLocal()) {
      Var arguments = scope.getArgumentsVar();
      ReferenceCollection refs = referenceMap.get(arguments);
      if (refs != null && !refs.references.isEmpty()) {
        for (Reference ref : refs.references) {
          Node refNode = ref.getNameNode();
          Node refParent = ref.getParent();
          // Any reference that is not a read of the arguments property
          // consider a escape of the arguments object.
          if (!(NodeUtil.isGet(refParent)
              && refNode == ref.getParent().getFirstChild()
              && !isLValue(refParent))) {
            return true;
          }
        }
      }
    }
    return false;
  }
248
  private boolean isLValue(Node n) {
    Node parent = n.getParent();
    return (parent.getType() == Token.INC
        || parent.getType() == Token.DEC
        || (NodeUtil.isAssignmentOp(parent)
        && parent.getFirstChild() == n));
  }
256
  private void inlineNonConstants(
      Var v, ReferenceCollection referenceInfo,
      boolean maybeModifiedArguments) {
    int refCount = referenceInfo.references.size();
    Reference declaration = referenceInfo.references.get(0);
    Reference init = referenceInfo.getInitializingReference();
    int firstRefAfterInit = (declaration == init) ? 2 : 3;
264
    if (refCount > 1 &&
…lines 266–297 unchanged (32 lines)
    }
299
    // If this variable was not inlined normally, check if we can
    // inline an alias of it. (If the variable was inlined, then the
    // reference data is out of sync. We're better off just waiting for
    // the next pass.)
    if (!maybeModifiedArguments &&
        !staleVars.contains(v) && referenceInfo.isWellDefined() &&
        referenceInfo.isAssignedOnceInLifetime()) {
      List<Reference> refs = referenceInfo.references;
      for (int i = 1 /* start from a read */; i < refs.size(); i++) {
        Node nameNode = refs.get(i).getNameNode();
        if (aliasCandidates.containsKey(nameNode)) {
…lines 311–723 unchanged (413 lines)

Before…lines 1–191 unchanged (191 lines)
  /**
   * For all variables in this scope, see if they are only used once.
   * If it looks safe to do so, inline them.
   */
  private void doInlinesForScope(NodeTraversal t,
      Map<Var, ReferenceCollection> referenceMap) {
198
    for (Iterator<Var> it = t.getScope().getVars(); it.hasNext();) {
      Var v = it.next();
201
      ReferenceCollection referenceInfo = referenceMap.get(v);
203
      // referenceInfo will be null if we're in constants-only mode
…lines 205–213 unchanged (9 lines)
        staleVars.add(v);
      } else if (mode == Mode.CONSTANTS_ONLY) {
        // If we're in constants-only mode, don't run more aggressive
        // inlining heuristics. See InlineConstantsTest.
        continue;
      } else {
        inlineNonConstants(v, referenceInfo);
      }
    }
  }
224
          // Any reference that is not a read of the arguments property
          // consider a escape of the arguments object.
227
228
  private void inlineNonConstants(
      Var v, ReferenceCollection referenceInfo) {
    int refCount = referenceInfo.references.size();
    Reference declaration = referenceInfo.references.get(0);
    Reference init = referenceInfo.getInitializingReference();
    int firstRefAfterInit = (declaration == init) ? 2 : 3;
235
    if (refCount > 1 &&
…lines 237–269 unchanged (33 lines)
270
    // If this variable was not inlined normally, check if we can
    // inline an alias of it. (If the variable was inlined, then the
    // reference data is out of sync. We're better off just waiting for
    // the next pass.)
    if (
        !staleVars.contains(v) && referenceInfo.isWellDefined() &&
        referenceInfo.isAssignedOnceInLifetime()) {
      List<Reference> refs = referenceInfo.references;
      for (int i = 1 /* start from a read */; i < refs.size(); i++) {
        Node nameNode = refs.get(i).getNameNode();
        if (aliasCandidates.containsKey(nameNode)) {
          AliasCandidate candidate = aliasCandidates.get(nameNode);
…lines 283–694 unchanged (412 lines)

After…lines 1–192 unchanged (192 lines)
   * For all variables in this scope, see if they are only used once.
   * If it looks safe to do so, inline them.
   */
  private void doInlinesForScope(NodeTraversal t,
      Map<Var, ReferenceCollection> referenceMap) {
198
    boolean maybeModifiedArguments =
        maybeEscapedOrModifiedArguments(t.getScope(), referenceMap);
    for (Iterator<Var> it = t.getScope().getVars(); it.hasNext();) {
      Var v = it.next();
203
      ReferenceCollection referenceInfo = referenceMap.get(v);
205
      // referenceInfo will be null if we're in constants-only mode
…lines 207–215 unchanged (9 lines)
        staleVars.add(v);
      } else if (mode == Mode.CONSTANTS_ONLY) {
        // If we're in constants-only mode, don't run more aggressive
        // inlining heuristics. See InlineConstantsTest.
        continue;
      } else {
        inlineNonConstants(v, referenceInfo, maybeModifiedArguments);
      }
    }
  }
226
  private boolean maybeEscapedOrModifiedArguments(
      Scope scope, Map<Var, ReferenceCollection> referenceMap) {
    if (scope.isLocal()) {
      Var arguments = scope.getArgumentsVar();
      ReferenceCollection refs = referenceMap.get(arguments);
      if (refs != null && !refs.references.isEmpty()) {
        for (Reference ref : refs.references) {
          Node refNode = ref.getNameNode();
          Node refParent = ref.getParent();
          // Any reference that is not a read of the arguments property
          // consider a escape of the arguments object.
          if (!(NodeUtil.isGet(refParent)
              && refNode == ref.getParent().getFirstChild()
              && !isLValue(refParent))) {
            return true;
          }
        }
      }
    }
    return false;
  }
248
  private boolean isLValue(Node n) {
    Node parent = n.getParent();
    return (parent.getType() == Token.INC
        || parent.getType() == Token.DEC
        || (NodeUtil.isAssignmentOp(parent)
        && parent.getFirstChild() == n));
  }
256
  private void inlineNonConstants(
      Var v, ReferenceCollection referenceInfo,
      boolean maybeModifiedArguments) {
    int refCount = referenceInfo.references.size();
    Reference declaration = referenceInfo.references.get(0);
    Reference init = referenceInfo.getInitializingReference();
    int firstRefAfterInit = (declaration == init) ? 2 : 3;
264
    if (refCount > 1 &&
…lines 266–297 unchanged (32 lines)
    }
299
    // If this variable was not inlined normally, check if we can
    // inline an alias of it. (If the variable was inlined, then the
    // reference data is out of sync. We're better off just waiting for
    // the next pass.)
    if (!maybeModifiedArguments &&
        !staleVars.contains(v) && referenceInfo.isWellDefined() &&
        referenceInfo.isAssignedOnceInLifetime()) {
      List<Reference> refs = referenceInfo.references;
      for (int i = 1 /* start from a read */; i < refs.size(); i++) {
        Node nameNode = refs.get(i).getNameNode();
        if (aliasCandidates.containsKey(nameNode)) {
…lines 311–723 unchanged (413 lines)

Before…lines 1–191 unchanged (191 lines)
  /**
   * For all variables in this scope, see if they are only used once.
   * If it looks safe to do so, inline them.
   */
  private void doInlinesForScope(NodeTraversal t,
      Map<Var, ReferenceCollection> referenceMap) {
198
    for (Iterator<Var> it = t.getScope().getVars(); it.hasNext();) {
      Var v = it.next();
201
      ReferenceCollection referenceInfo = referenceMap.get(v);
203
      // referenceInfo will be null if we're in constants-only mode
…lines 205–213 unchanged (9 lines)
        staleVars.add(v);
      } else if (mode == Mode.CONSTANTS_ONLY) {
        // If we're in constants-only mode, don't run more aggressive
        // inlining heuristics. See InlineConstantsTest.
        continue;
      } else {
        inlineNonConstants(v, referenceInfo);
      }
    }
  }
224
          // Any reference that is not a read of the arguments property
          // consider a escape of the arguments object.
227
228
  private void inlineNonConstants(
      Var v, ReferenceCollection referenceInfo) {
    int refCount = referenceInfo.references.size();
    Reference declaration = referenceInfo.references.get(0);
    Reference init = referenceInfo.getInitializingReference();
    int firstRefAfterInit = (declaration == init) ? 2 : 3;
235
    if (refCount > 1 &&
…lines 237–269 unchanged (33 lines)
270
    // If this variable was not inlined normally, check if we can
    // inline an alias of it. (If the variable was inlined, then the
    // reference data is out of sync. We're better off just waiting for
    // the next pass.)
    if (
        !staleVars.contains(v) && referenceInfo.isWellDefined() &&
        referenceInfo.isAssignedOnceInLifetime()) {
      List<Reference> refs = referenceInfo.references;
      for (int i = 1 /* start from a read */; i < refs.size(); i++) {
        Node nameNode = refs.get(i).getNameNode();
        if (aliasCandidates.containsKey(nameNode)) {
          AliasCandidate candidate = aliasCandidates.get(nameNode);
…lines 283–694 unchanged (412 lines)

After…lines 1–192 unchanged (192 lines)
   * For all variables in this scope, see if they are only used once.
   * If it looks safe to do so, inline them.
   */
  private void doInlinesForScope(NodeTraversal t,
      Map<Var, ReferenceCollection> referenceMap) {
198
    boolean maybeModifiedArguments =
        maybeEscapedOrModifiedArguments(t.getScope(), referenceMap);
    for (Iterator<Var> it = t.getScope().getVars(); it.hasNext();) {
      Var v = it.next();
203
      ReferenceCollection referenceInfo = referenceMap.get(v);
205
      // referenceInfo will be null if we're in constants-only mode
…lines 207–215 unchanged (9 lines)
        staleVars.add(v);
      } else if (mode == Mode.CONSTANTS_ONLY) {
        // If we're in constants-only mode, don't run more aggressive
        // inlining heuristics. See InlineConstantsTest.
        continue;
      } else {
        inlineNonConstants(v, referenceInfo, maybeModifiedArguments);
      }
    }
  }
226
  private boolean maybeEscapedOrModifiedArguments(
      Scope scope, Map<Var, ReferenceCollection> referenceMap) {
    if (scope.isLocal()) {
      Var arguments = scope.getArgumentsVar();
      ReferenceCollection refs = referenceMap.get(arguments);
      if (refs != null && !refs.references.isEmpty()) {
        for (Reference ref : refs.references) {
          Node refNode = ref.getNameNode();
          Node refParent = ref.getParent();
          // Any reference that is not a read of the arguments property
          // consider a escape of the arguments object.
          if (!(NodeUtil.isGet(refParent)
              && refNode == ref.getParent().getFirstChild()
              && !isLValue(refParent))) {
            return true;
          }
        }
      }
    }
    return false;
  }
248
  private boolean isLValue(Node n) {
    Node parent = n.getParent();
    return (parent.getType() == Token.INC
        || parent.getType() == Token.DEC
        || (NodeUtil.isAssignmentOp(parent)
        && parent.getFirstChild() == n));
  }
256
  private void inlineNonConstants(
      Var v, ReferenceCollection referenceInfo,
      boolean maybeModifiedArguments) {
    int refCount = referenceInfo.references.size();
    Reference declaration = referenceInfo.references.get(0);
    Reference init = referenceInfo.getInitializingReference();
    int firstRefAfterInit = (declaration == init) ? 2 : 3;
264
    if (refCount > 1 &&
…lines 266–297 unchanged (32 lines)
    }
299
    // If this variable was not inlined normally, check if we can
    // inline an alias of it. (If the variable was inlined, then the
    // reference data is out of sync. We're better off just waiting for
    // the next pass.)
    if (!maybeModifiedArguments &&
        !staleVars.contains(v) && referenceInfo.isWellDefined() &&
        referenceInfo.isAssignedOnceInLifetime()) {
      List<Reference> refs = referenceInfo.references;
      for (int i = 1 /* start from a read */; i < refs.size(); i++) {
        Node nameNode = refs.get(i).getNameNode();
        if (aliasCandidates.containsKey(nameNode)) {
…lines 311–723 unchanged (413 lines)

Before

program

package_declaration

package "package"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "base"

. "."

identifier "Preconditions"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "base"

. "."

identifier "Predicate"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "base"

. "."

identifier "Predicates"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "collect"

. "."

identifier "Maps"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "collect"

. "."

identifier "Sets"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

. "."

identifier "CodingConvention"

. "."

identifier "SubclassRelationship"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

. "."

identifier "ReferenceCollectingCallback"

. "."

identifier "Behavior"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

. "."

identifier "ReferenceCollectingCallback"

. "."

identifier "Reference"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

. "."

identifier "ReferenceCollectingCallback"

. "."

identifier "ReferenceCollection"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

. "."

identifier "Scope"

. "."

identifier "Var"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "Node"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "Token"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "java"

. "."

identifier "util"

. "."

identifier "Iterator"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "java"

. "."

identifier "util"

. "."

identifier "List"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "java"

. "."

identifier "util"

. "."

identifier "Map"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "java"

. "."

identifier "util"

. "."

identifier "Set"

; ";"

block_comment "/**\n * Using the infrastructure provided by VariableReferenc"...

class_declaration

class "class"

identifier "InlineVariables"

super_interfaces

implements "implements"

type_list

type_identifier "CompilerPass"

class_body

{ "{"

field_declaration

modifiers

private "private"

final "final"

type_identifier "AbstractCompiler"

variable_declarator

identifier "compiler"

; ";"

enum_declaration

enum "enum"

identifier "Mode"

enum_body

{ "{"

line_comment "// Only inline things explicitly marked as constant."

enum_constant

identifier "CONSTANTS_ONLY"

, ","

line_comment "// Locals only"

enum_constant

identifier "LOCALS_ONLY"

, ","

enum_constant

identifier "ALL"

} "}"

field_declaration

modifiers

private "private"

final "final"

type_identifier "Mode"

variable_declarator

identifier "mode"

; ";"

line_comment "// Inlines all strings, even if they increase the size of th"...

field_declaration

modifiers

private "private"

final "final"

boolean_type "boolean"

variable_declarator

identifier "inlineAllStrings"

; ";"

field_declaration

modifiers

private "private"

final "final"

type_identifier "IdentifyConstants"

variable_declarator

identifier "identifyConstants"

= "="

object_creation_expression

new "new"

type_identifier "IdentifyConstants"

argument_list

( "("

) ")"

; ";"

constructor_declaration (+46 nodes collapsed)

method_declaration (+59 nodes collapsed)

method_declaration (+85 nodes collapsed)

block_comment "/**\n * Filters variables declared as \"constant\", and decla"...

class_declaration (+44 nodes collapsed)

block_comment "/**\n * Filters non-global variables.\n */"

class_declaration (+47 nodes collapsed)

class_declaration (+58 nodes collapsed)

block_comment "/**\n * Builds up information about nodes in each scope. Wh"...

class_declaration

modifiers

private "private"

class "class"

identifier "InliningBehavior"

super_interfaces

implements "implements"

type_list

type_identifier "Behavior"

class_body

{ "{"

block_comment "/**\n * A list of variables that should not be inlined, b"...

field_declaration (+21 nodes collapsed)

block_comment "/**\n * Stored possible aliases of variables that never c"...

field_declaration (+22 nodes collapsed)

method_declaration (+48 nodes collapsed)

block_comment "/**\n * If any of the variables are well-defined and alia"...

method_declaration (+227 nodes collapsed)

block_comment "/**\n * For all variables in this scope, see if they are "...

method_declaration

modifiers

private "private"

void_type "void"

identifier "doInlinesForScope"

formal_parameters

( "("

formal_parameter

type_identifier "NodeTraversal"

identifier "t"

, ","

formal_parameter

generic_type

type_identifier "Map"

type_arguments

< "<"

type_identifier "Var"

, ","

type_identifier "ReferenceCollection"

> ">"

identifier "referenceMap"

) ")"

block

{ "{"

for_statement

for "for"

( "("

local_variable_declaration (+24 nodes collapsed)

method_invocation

identifier "it"

. "."

identifier "hasNext"

argument_list

( "("

) ")"

; ";"

) ")"

block

{ "{"

local_variable_declaration

type_identifier "Var"

variable_declarator

identifier "v"

= "="

method_invocation

identifier "it"

. "."

identifier "next"

argument_list

( "("

) ")"

; ";"

local_variable_declaration

type_identifier "ReferenceCollection"

variable_declarator

identifier "referenceInfo"

= "="

method_invocation

identifier "referenceMap"

. "."

identifier "get"

argument_list

( "("

identifier "v"

) ")"

; ";"

line_comment "// referenceInfo will be null if we're in constants-only mod"...

line_comment "// and the variable is not a constant."

if_statement

if "if"

parenthesized_expression

( "("

binary_expression

identifier "referenceInfo"

== "=="

null_literal "null"

|| "||"

method_invocation

identifier "isVarInlineForbidden"

argument_list

( "("

identifier "v"

) ")"

block

{ "{"

line_comment "// Never try to inline exported variables or variables that"

line_comment "// were not collected or variables that have already been in"...

continue_statement

continue "continue"

; ";"

} "}"

else "else"

if_statement

if "if"

parenthesized_expression

( "("

method_invocation

identifier "isInlineableDeclaredConstant"

argument_list

( "("

identifier "v"

, ","

identifier "referenceInfo"

) ")"

block (+54 nodes collapsed)

else "else"

if_statement

if "if"

parenthesized_expression

( "("

binary_expression

identifier "mode"

== "=="

field_access

identifier "Mode"

. "."

identifier "CONSTANTS_ONLY"

) ")"

block

{ "{"

line_comment "// If we're in constants-only mode, don't run more aggressiv"...

line_comment "// inlining heuristics. See InlineConstantsTest."

continue_statement

continue "continue"

; ";"

} "}"

else "else"

block

{ "{"

expression_statement

method_invocation

identifier "inlineNonConstants"

argument_list

( "("

identifier "v"

, ","

identifier "referenceInfo"

) ")"

; ";"

} "}"

line_comment "// Any reference that is not a read of the arguments propert"...

line_comment "// consider a escape of the arguments object."

method_declaration

modifiers

private "private"

void_type "void"

identifier "inlineNonConstants"

formal_parameters

( "("

formal_parameter

type_identifier "Var"

identifier "v"

, ","

formal_parameter

type_identifier "ReferenceCollection"

identifier "referenceInfo"

) ")"

block

{ "{"

local_variable_declaration

integral_type

int "int"

variable_declarator

identifier "refCount"

= "="

method_invocation

field_access

identifier "referenceInfo"

. "."

identifier "references"

. "."

identifier "size"

argument_list

( "("

) ")"

; ";"

local_variable_declaration

type_identifier "Reference"

variable_declarator

identifier "declaration"

= "="

method_invocation

field_access

identifier "referenceInfo"

. "."

identifier "references"

. "."

identifier "get"

argument_list

( "("

decimal_integer_literal "0"

) ")"

; ";"

local_variable_declaration

type_identifier "Reference"

variable_declarator

identifier "init"

= "="

method_invocation

identifier "referenceInfo"

. "."

identifier "getInitializingReference"

argument_list

( "("

) ")"

; ";"

local_variable_declaration

integral_type

int "int"

variable_declarator

identifier "firstRefAfterInit"

= "="

ternary_expression

parenthesized_expression

( "("

binary_expression

identifier "declaration"

== "=="

identifier "init"

) ")"

? "?"

decimal_integer_literal "2"

: ":"

decimal_integer_literal "3"

; ";"

if_statement (+287 nodes collapsed)

line_comment "// If this variable was not inlined normally, check if we ca"...

line_comment "// inline an alias of it. (If the variable was inlined, then"...

line_comment "// reference data is out of sync. We're better off just wait"...

line_comment "// the next pass.)"

if_statement

if "if"

parenthesized_expression

( "("

binary_expression any 2:3

unary_expression

! "!"

method_invocation

identifier "staleVars"

. "."

identifier "contains"

argument_list

( "("

identifier "v"

) ")"

&& "&&"

method_invocation

identifier "referenceInfo"

. "."

identifier "isWellDefined"

argument_list

( "("

) ")"

&& "&&"

method_invocation

identifier "referenceInfo"

. "."

identifier "isAssignedOnceInLifetime"

argument_list

( "("

) ")"

block (+209 nodes collapsed)

} "}"

block_comment "/**\n * If there are any variable references in the given"...

method_declaration (+107 nodes collapsed)

block_comment "/**\n * Whether the given variable is forbidden from bein"...

method_declaration (+66 nodes collapsed)

block_comment "/**\n * Do the actual work of inlining a single declarati"...

method_declaration (+183 nodes collapsed)

block_comment "/**\n * Inline an immutable variable into all of its refe"...

method_declaration (+103 nodes collapsed)

block_comment "/**\n * Inline a declared constant.\n */"

method_declaration (+106 nodes collapsed)

block_comment "/**\n * Remove the given VAR declaration.\n */"

method_declaration (+117 nodes collapsed)

block_comment "/**\n * Replace the given reference with the given value "...

method_declaration (+112 nodes collapsed)

block_comment "/**\n * Determines whether the given variable is declared"...

method_declaration (+175 nodes collapsed)

block_comment "/**\n * Compute whether the given string is worth inlinin"...

method_declaration (+171 nodes collapsed)

block_comment "/**\n * @return true if the provided reference and declar"...

method_declaration (+373 nodes collapsed)

block_comment "/**\n * If the value is a literal, we can cross more boun"...

method_declaration (+44 nodes collapsed)

block_comment "/**\n * If the value of a variable is not constant, then "...

method_declaration (+303 nodes collapsed)

block_comment "/**\n * @return true if the reference is a normal VAR or "...

method_declaration (+76 nodes collapsed)

block_comment "/**\n * @return Whether there is a initial value.\n */"

method_declaration (+144 nodes collapsed)

block_comment "/**\n * @return true if the reference is a candidate for "...

method_declaration (+37 nodes collapsed)

block_comment "/**\n * Determines whether the reference collection descr"...

method_declaration (+378 nodes collapsed)

} "}"

After

program

package_declaration

package "package"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "base"

. "."

identifier "Preconditions"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "base"

. "."

identifier "Predicate"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "base"

. "."

identifier "Predicates"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "collect"

. "."

identifier "Maps"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "collect"

. "."

identifier "Sets"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

. "."

identifier "CodingConvention"

. "."

identifier "SubclassRelationship"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

. "."

identifier "ReferenceCollectingCallback"

. "."

identifier "Behavior"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

. "."

identifier "ReferenceCollectingCallback"

. "."

identifier "Reference"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

. "."

identifier "ReferenceCollectingCallback"

. "."

identifier "ReferenceCollection"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

. "."

identifier "Scope"

. "."

identifier "Var"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "Node"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "Token"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "java"

. "."

identifier "util"

. "."

identifier "Iterator"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "java"

. "."

identifier "util"

. "."

identifier "List"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "java"

. "."

identifier "util"

. "."

identifier "Map"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "java"

. "."

identifier "util"

. "."

identifier "Set"

; ";"

block_comment "/**\n * Using the infrastructure provided by VariableReferenc"...

class_declaration

class "class"

identifier "InlineVariables"

super_interfaces

implements "implements"

type_list

type_identifier "CompilerPass"

class_body

{ "{"

field_declaration

modifiers

private "private"

final "final"

type_identifier "AbstractCompiler"

variable_declarator

identifier "compiler"

; ";"

enum_declaration

enum "enum"

identifier "Mode"

enum_body

{ "{"

line_comment "// Only inline things explicitly marked as constant."

enum_constant

identifier "CONSTANTS_ONLY"

, ","

line_comment "// Locals only"

enum_constant

identifier "LOCALS_ONLY"

, ","

enum_constant

identifier "ALL"

} "}"

field_declaration

modifiers

private "private"

final "final"

type_identifier "Mode"

variable_declarator

identifier "mode"

; ";"

line_comment "// Inlines all strings, even if they increase the size of th"...

field_declaration

modifiers

private "private"

final "final"

boolean_type "boolean"

variable_declarator

identifier "inlineAllStrings"

; ";"

field_declaration

modifiers

private "private"

final "final"

type_identifier "IdentifyConstants"

variable_declarator

identifier "identifyConstants"

= "="

object_creation_expression

new "new"

type_identifier "IdentifyConstants"

argument_list

( "("

) ")"

; ";"

constructor_declaration (+46 nodes collapsed)

method_declaration (+59 nodes collapsed)

method_declaration (+85 nodes collapsed)

block_comment "/**\n * Filters variables declared as \"constant\", and decla"...

class_declaration (+44 nodes collapsed)

block_comment "/**\n * Filters non-global variables.\n */"

class_declaration (+47 nodes collapsed)

class_declaration (+58 nodes collapsed)

block_comment "/**\n * Builds up information about nodes in each scope. Wh"...

class_declaration

modifiers

private "private"

class "class"

identifier "InliningBehavior"

super_interfaces

implements "implements"

type_list

type_identifier "Behavior"

class_body

{ "{"

block_comment "/**\n * A list of variables that should not be inlined, b"...

field_declaration (+21 nodes collapsed)

block_comment "/**\n * Stored possible aliases of variables that never c"...

field_declaration (+22 nodes collapsed)

method_declaration (+48 nodes collapsed)

block_comment "/**\n * If any of the variables are well-defined and alia"...

method_declaration (+227 nodes collapsed)

block_comment "/**\n * For all variables in this scope, see if they are "...

method_declaration

modifiers

private "private"

void_type "void"

identifier "doInlinesForScope"

formal_parameters

( "("

formal_parameter

type_identifier "NodeTraversal"

identifier "t"

, ","

formal_parameter

generic_type

type_identifier "Map"

type_arguments

< "<"

type_identifier "Var"

, ","

type_identifier "ReferenceCollection"

> ">"

identifier "referenceMap"

) ")"

block

{ "{"

local_variable_declaration

boolean_type "boolean"

variable_declarator

identifier "maybeModifiedArguments"

= "="

method_invocation

identifier "maybeEscapedOrModifiedArguments"

argument_list

( "("

method_invocation

identifier "t"

. "."

identifier "getScope"

argument_list

( "("

) ")"

, ","

identifier "referenceMap"

) ")"

; ";"

for_statement

for "for"

( "("

local_variable_declaration (+24 nodes collapsed)

method_invocation

identifier "it"

. "."

identifier "hasNext"

argument_list

( "("

) ")"

; ";"

) ")"

block

{ "{"

local_variable_declaration

type_identifier "Var"

variable_declarator

identifier "v"

= "="

method_invocation

identifier "it"

. "."

identifier "next"

argument_list

( "("

) ")"

; ";"

local_variable_declaration

type_identifier "ReferenceCollection"

variable_declarator

identifier "referenceInfo"

= "="

method_invocation

identifier "referenceMap"

. "."

identifier "get"

argument_list

( "("

identifier "v"

) ")"

; ";"

line_comment "// referenceInfo will be null if we're in constants-only mod"...

line_comment "// and the variable is not a constant."

if_statement

if "if"

parenthesized_expression

( "("

binary_expression

identifier "referenceInfo"

== "=="

null_literal "null"

|| "||"

method_invocation

identifier "isVarInlineForbidden"

argument_list

( "("

identifier "v"

) ")"

block

{ "{"

line_comment "// Never try to inline exported variables or variables that"

line_comment "// were not collected or variables that have already been in"...

continue_statement

continue "continue"

; ";"

} "}"

else "else"

if_statement

if "if"

parenthesized_expression

( "("

method_invocation

identifier "isInlineableDeclaredConstant"

argument_list

( "("

identifier "v"

, ","

identifier "referenceInfo"

) ")"

block (+54 nodes collapsed)

else "else"

if_statement

if "if"

parenthesized_expression

( "("

binary_expression

identifier "mode"

== "=="

field_access

identifier "Mode"

. "."

identifier "CONSTANTS_ONLY"

) ")"

block

{ "{"

line_comment "// If we're in constants-only mode, don't run more aggressiv"...

line_comment "// inlining heuristics. See InlineConstantsTest."

continue_statement

continue "continue"

; ";"

} "}"

else "else"

block

{ "{"

expression_statement

method_invocation

identifier "inlineNonConstants"

argument_list

( "("

identifier "v"

, ","

identifier "referenceInfo"

, ","

identifier "maybeModifiedArguments"

) ")"

; ";"

} "}"

method_declaration

modifiers

private "private"

boolean_type "boolean"

identifier "maybeEscapedOrModifiedArguments"

formal_parameters

( "("

formal_parameter

type_identifier "Scope"

identifier "scope"

, ","

formal_parameter

generic_type

type_identifier "Map"

type_arguments

< "<"

type_identifier "Var"

, ","

type_identifier "ReferenceCollection"

> ">"

identifier "referenceMap"

) ")"

block

{ "{"

if_statement

if "if"

parenthesized_expression

( "("

method_invocation

identifier "scope"

. "."

identifier "isLocal"

argument_list

( "("

) ")"

block

{ "{"

local_variable_declaration

type_identifier "Var"

variable_declarator

identifier "arguments"

= "="

method_invocation

identifier "scope"

. "."

identifier "getArgumentsVar"

argument_list

( "("

) ")"

; ";"

local_variable_declaration

type_identifier "ReferenceCollection"

variable_declarator

identifier "refs"

= "="

method_invocation

identifier "referenceMap"

. "."

identifier "get"

argument_list

( "("

identifier "arguments"

) ")"

; ";"

if_statement

if "if"

parenthesized_expression

( "("

binary_expression

identifier "refs"

!= "!="

null_literal "null"

&& "&&"

unary_expression

! "!"

method_invocation

field_access

identifier "refs"

. "."

identifier "references"

. "."

identifier "isEmpty"

argument_list

( "("

) ")"

block

{ "{"

enhanced_for_statement

for "for"

( "("

type_identifier "Reference"

identifier "ref"

: ":"

field_access

identifier "refs"

. "."

identifier "references"

) ")"

block

{ "{"

local_variable_declaration

type_identifier "Node"

variable_declarator

identifier "refNode"

= "="

method_invocation

identifier "ref"

. "."

identifier "getNameNode"

argument_list

( "("

) ")"

; ";"

local_variable_declaration

type_identifier "Node"

variable_declarator

identifier "refParent"

= "="

method_invocation

identifier "ref"

. "."

identifier "getParent"

argument_list

( "("

) ")"

; ";"

line_comment "// Any reference that is not a read of the arguments propert"...

line_comment "// consider a escape of the arguments object."

if_statement

if "if"

parenthesized_expression

( "("

unary_expression

! "!"

parenthesized_expression

( "("

binary_expression

method_invocation

identifier "NodeUtil"

. "."

identifier "isGet"

argument_list

( "("

identifier "refParent"

) ")"

&& "&&"

binary_expression

identifier "refNode"

== "=="

method_invocation

identifier "ref"

. "."

identifier "getParent"

argument_list

( "("

) ")"

. "."

identifier "getFirstChild"

argument_list

( "("

) ")"

&& "&&"

unary_expression

! "!"

method_invocation

identifier "isLValue"

argument_list

( "("

identifier "refParent"

) ")"

block

{ "{"

return_statement

return "return"

true "true"

; ";"

} "}"

return_statement

return "return"

false "false"

; ";"

} "}"

method_declaration

modifiers

private "private"

boolean_type "boolean"

identifier "isLValue"

formal_parameters

( "("

formal_parameter

type_identifier "Node"

identifier "n"

) ")"

block

{ "{"

local_variable_declaration

type_identifier "Node"

variable_declarator

identifier "parent"

= "="

method_invocation

identifier "n"

. "."

identifier "getParent"

argument_list

( "("

) ")"

; ";"

return_statement

return "return"

parenthesized_expression

( "("

binary_expression

method_invocation

identifier "parent"

. "."

identifier "getType"

argument_list

( "("

) ")"

== "=="

field_access

identifier "Token"

. "."

identifier "INC"

|| "||"

binary_expression

method_invocation

identifier "parent"

. "."

identifier "getType"

argument_list

( "("

) ")"

== "=="

field_access

identifier "Token"

. "."

identifier "DEC"

|| "||"

parenthesized_expression

( "("

binary_expression

method_invocation

identifier "NodeUtil"

. "."

identifier "isAssignmentOp"

argument_list

( "("

identifier "parent"

) ")"

&& "&&"

binary_expression

method_invocation

identifier "parent"

. "."

identifier "getFirstChild"

argument_list

( "("

) ")"

== "=="

identifier "n"

) ")"

; ";"

} "}"

method_declaration

modifiers

private "private"

void_type "void"

identifier "inlineNonConstants"

formal_parameters

( "("

formal_parameter

type_identifier "Var"

identifier "v"

, ","

formal_parameter

type_identifier "ReferenceCollection"

identifier "referenceInfo"

, ","

formal_parameter

boolean_type "boolean"

identifier "maybeModifiedArguments"

) ")"

block

{ "{"

local_variable_declaration

integral_type

int "int"

variable_declarator

identifier "refCount"

= "="

method_invocation

field_access

identifier "referenceInfo"

. "."

identifier "references"

. "."

identifier "size"

argument_list

( "("

) ")"

; ";"

local_variable_declaration

type_identifier "Reference"

variable_declarator

identifier "declaration"

= "="

method_invocation

field_access

identifier "referenceInfo"

. "."

identifier "references"

. "."

identifier "get"

argument_list

( "("

decimal_integer_literal "0"

) ")"

; ";"

local_variable_declaration

type_identifier "Reference"

variable_declarator

identifier "init"

= "="

method_invocation

identifier "referenceInfo"

. "."

identifier "getInitializingReference"

argument_list

( "("

) ")"

; ";"

local_variable_declaration

integral_type

int "int"

variable_declarator

identifier "firstRefAfterInit"

= "="

ternary_expression

parenthesized_expression

( "("

binary_expression

identifier "declaration"

== "=="

identifier "init"

) ")"

? "?"

decimal_integer_literal "2"

: ":"

decimal_integer_literal "3"

; ";"

if_statement (+287 nodes collapsed)

line_comment "// If this variable was not inlined normally, check if we ca"...

line_comment "// inline an alias of it. (If the variable was inlined, then"...

line_comment "// reference data is out of sync. We're better off just wait"...

line_comment "// the next pass.)"

if_statement

if "if"

parenthesized_expression

( "("

binary_expression any 2:3

unary_expression

! "!"

identifier "maybeModifiedArguments"

&& "&&"

unary_expression

! "!"

method_invocation

identifier "staleVars"

. "."

identifier "contains"

argument_list

( "("

identifier "v"

) ")"

&& "&&"

method_invocation

identifier "referenceInfo"

. "."

identifier "isWellDefined"

argument_list

( "("

) ")"

&& "&&"

method_invocation

identifier "referenceInfo"

. "."

identifier "isAssignedOnceInLifetime"

argument_list

( "("

) ")"

block (+209 nodes collapsed)

} "}"

block_comment "/**\n * If there are any variable references in the given"...

method_declaration (+107 nodes collapsed)

block_comment "/**\n * Whether the given variable is forbidden from bein"...

method_declaration (+66 nodes collapsed)

block_comment "/**\n * Do the actual work of inlining a single declarati"...

method_declaration (+183 nodes collapsed)

block_comment "/**\n * Inline an immutable variable into all of its refe"...

method_declaration (+103 nodes collapsed)

block_comment "/**\n * Inline a declared constant.\n */"

method_declaration (+106 nodes collapsed)

block_comment "/**\n * Remove the given VAR declaration.\n */"

method_declaration (+117 nodes collapsed)

block_comment "/**\n * Replace the given reference with the given value "...

method_declaration (+112 nodes collapsed)

block_comment "/**\n * Determines whether the given variable is declared"...

method_declaration (+175 nodes collapsed)

block_comment "/**\n * Compute whether the given string is worth inlinin"...

method_declaration (+171 nodes collapsed)

block_comment "/**\n * @return true if the provided reference and declar"...

method_declaration (+373 nodes collapsed)

block_comment "/**\n * If the value is a literal, we can cross more boun"...

method_declaration (+44 nodes collapsed)

block_comment "/**\n * If the value of a variable is not constant, then "...

method_declaration (+303 nodes collapsed)

block_comment "/**\n * @return true if the reference is a normal VAR or "...

method_declaration (+76 nodes collapsed)

block_comment "/**\n * @return Whether there is a initial value.\n */"

method_declaration (+144 nodes collapsed)

block_comment "/**\n * @return true if the reference is a candidate for "...

method_declaration (+37 nodes collapsed)

block_comment "/**\n * Determines whether the reference collection descr"...

method_declaration (+378 nodes collapsed)

} "}"