java-defects4j-closure-139-normalize

A painting is a person's account of this edit as text, recorded independently of the node mapping - a rendering often has several equally defensible answers where the mapping has one. Deletions and insertions carry no position on the opposite side in a painting, so that panel draws no caret for them.

Before

program

package_declaration

package "package"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "base"

. "."

identifier "Preconditions"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "collect"

. "."

identifier "Lists"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "collect"

. "."

identifier "Maps"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

. "."

identifier "NodeTraversal"

. "."

identifier "AbstractPostOrderCallback"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

. "."

identifier "NodeTraversal"

. "."

identifier "Callback"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

. "."

identifier "Scope"

. "."

identifier "Var"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "JSDocInfo"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "Node"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "Token"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "java"

. "."

identifier "util"

. "."

identifier "Map"

; ";"

block_comment "/**\n * The goal with this pass is to simplify the other pass"...

line_comment "// public for ReplaceDebugStringsTest"

class_declaration

class "class"

identifier "Normalize"

super_interfaces

implements "implements"

type_list

type_identifier "CompilerPass"

class_body

{ "{"

field_declaration

modifiers

private "private"

final "final"

type_identifier "AbstractCompiler"

variable_declarator

identifier "compiler"

; ";"

field_declaration

modifiers

private "private"

final "final"

boolean_type "boolean"

variable_declarator

identifier "assertOnChange"

; ";"

field_declaration

modifiers

private "private"

static "static"

final "final"

boolean_type "boolean"

variable_declarator

identifier "CONVERT_WHILE_TO_FOR"

= "="

true "true"

; ";"

field_declaration

modifiers

static "static"

final "final"

boolean_type "boolean"

variable_declarator

identifier "MAKE_LOCAL_NAMES_UNIQUE"

= "="

true "true"

; ";"

constructor_declaration (+33 nodes collapsed)

method_declaration (+49 nodes collapsed)

method_declaration (+133 nodes collapsed)

class_declaration (+372 nodes collapsed)

block_comment "/**\n * Walk the AST tree and verify that constant names ar"...

class_declaration (+585 nodes collapsed)

block_comment "/**\n * Simplify the AST:\n * - VAR declarations split, "...

class_declaration

modifiers

static "static"

class "class"

identifier "NormalizeStatements"

super_interfaces

implements "implements"

type_list

type_identifier "Callback"

class_body

{ "{"

field_declaration

modifiers

private "private"

final "final"

type_identifier "AbstractCompiler"

variable_declarator

identifier "compiler"

; ";"

field_declaration

modifiers

private "private"

final "final"

boolean_type "boolean"

variable_declarator

identifier "assertOnChange"

; ";"

constructor_declaration (+33 nodes collapsed)

method_declaration (+49 nodes collapsed)

method_declaration (+41 nodes collapsed)

method_declaration

modifiers

marker_annotation

@ "@"

identifier "Override"

public "public"

void_type "void"

identifier "visit"

formal_parameters

( "("

formal_parameter

type_identifier "NodeTraversal"

identifier "t"

, ","

formal_parameter

type_identifier "Node"

identifier "n"

, ","

formal_parameter

type_identifier "Node"

identifier "parent"

) ")"

block

{ "{"

switch_expression

switch "switch"

parenthesized_expression

( "("

method_invocation

identifier "n"

. "."

identifier "getType"

argument_list

( "("

) ")"

switch_block

{ "{"

switch_block_statement_group (+99 nodes collapsed)

} "}"

block_comment "/**\n * Rewrite named unhoisted functions declarations to"...

block_comment "/**\n * Rewrite the function declaration from:\n * f"...

line_comment "// Prepare a spot for the function."

line_comment "// Prepare the function"

line_comment "// Move the function"

block_comment "/**\n * Do normalizations that introduce new siblings or "...

method_declaration (+157 nodes collapsed)

line_comment "// TODO(johnlenz): Move this to NodeTypeNormalizer once the "...

line_comment "// fixed."

block_comment "/**\n * Limit the number of special cases where LABELs ne"...

method_declaration (+163 nodes collapsed)

block_comment "/**\n * Bring the initializers out of FOR loops. These n"...

method_declaration (+298 nodes collapsed)

block_comment "/**\n * Split a var node such as:\n * var a, b;\n "...

method_declaration (+216 nodes collapsed)

block_comment "/**\n * Move all the functions that are valid at the exec"...

method_declaration (+220 nodes collapsed)

block_comment "/**\n * @param after The child node to insert the newChil"...

method_declaration (+64 nodes collapsed)

} "}"

block_comment "/**\n * Remove duplicate VAR declarations.\n */"

method_declaration (+73 nodes collapsed)

block_comment "/**\n * ScopeCreator duplicate declaration handler.\n */"

class_declaration

modifiers

private "private"

final "final"

class "class"

identifier "DuplicateDeclarationHandler"

super_interfaces

implements "implements"

type_list

scoped_type_identifier

type_identifier "SyntacticScopeCreator"

. "."

type_identifier "RedeclarationHandler"

class_body

{ "{"

block_comment "/**\n * Remove duplicate VAR declarations encountered dis"...

method_declaration

modifiers

marker_annotation

@ "@"

identifier "Override"

public "public"

void_type "void"

identifier "onRedeclaration"

formal_parameters (+26 nodes collapsed)

block

{ "{"

expression_statement (+22 nodes collapsed)

if_statement

if "if"

parenthesized_expression

( "("

binary_expression

method_invocation

identifier "parent"

. "."

identifier "getType"

argument_list

( "("

) ")"

== "=="

field_access

identifier "Token"

. "."

identifier "VAR"

) ")"

block

{ "{"

line_comment "// If name is \"arguments\", Var maybe null."

expression_statement

method_invocation

identifier "Preconditions"

. "."

identifier "checkState"

argument_list

( "("

method_invocation

identifier "parent"

. "."

identifier "hasOneChild"

argument_list

( "("

) ")"

; ";"

expression_statement

method_invocation

identifier "replaceVarWithAssignment"

argument_list

( "("

identifier "n"

, ","

identifier "parent"

, ","

identifier "gramps"

) ")"

; ";"

} "}"

block_comment "/**\n * Remove the parent VAR. There are three cases that"...

method_declaration (+251 nodes collapsed)

} "}"

block_comment "/**\n * A simple class that causes scope to be created.\n "...

class_declaration (+117 nodes collapsed)

} "}"

After

program

package_declaration

package "package"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "base"

. "."

identifier "Preconditions"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "collect"

. "."

identifier "Lists"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "common"

. "."

identifier "collect"

. "."

identifier "Maps"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

. "."

identifier "NodeTraversal"

. "."

identifier "AbstractPostOrderCallback"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

. "."

identifier "NodeTraversal"

. "."

identifier "Callback"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "jscomp"

. "."

identifier "Scope"

. "."

identifier "Var"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "JSDocInfo"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "Node"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "com"

. "."

identifier "google"

. "."

identifier "javascript"

. "."

identifier "rhino"

. "."

identifier "Token"

; ";"

import_declaration

import "import"

scoped_identifier

identifier "java"

. "."

identifier "util"

. "."

identifier "Map"

; ";"

block_comment "/**\n * The goal with this pass is to simplify the other pass"...

line_comment "// public for ReplaceDebugStringsTest"

class_declaration

class "class"

identifier "Normalize"

super_interfaces

implements "implements"

type_list

type_identifier "CompilerPass"

class_body

{ "{"

field_declaration

modifiers

private "private"

final "final"

type_identifier "AbstractCompiler"

variable_declarator

identifier "compiler"

; ";"

field_declaration

modifiers

private "private"

final "final"

boolean_type "boolean"

variable_declarator

identifier "assertOnChange"

; ";"

field_declaration

modifiers

private "private"

static "static"

final "final"

boolean_type "boolean"

variable_declarator

identifier "CONVERT_WHILE_TO_FOR"

= "="

true "true"

; ";"

field_declaration

modifiers

static "static"

final "final"

boolean_type "boolean"

variable_declarator

identifier "MAKE_LOCAL_NAMES_UNIQUE"

= "="

true "true"

; ";"

constructor_declaration (+33 nodes collapsed)

method_declaration (+49 nodes collapsed)

method_declaration (+133 nodes collapsed)

class_declaration (+372 nodes collapsed)

block_comment "/**\n * Walk the AST tree and verify that constant names ar"...

class_declaration (+585 nodes collapsed)

block_comment "/**\n * Simplify the AST:\n * - VAR declarations split, "...

class_declaration

modifiers

static "static"

class "class"

identifier "NormalizeStatements"

super_interfaces

implements "implements"

type_list

type_identifier "Callback"

class_body

{ "{"

field_declaration

modifiers

private "private"

final "final"

type_identifier "AbstractCompiler"

variable_declarator

identifier "compiler"

; ";"

field_declaration

modifiers

private "private"

final "final"

boolean_type "boolean"

variable_declarator

identifier "assertOnChange"

; ";"

constructor_declaration (+33 nodes collapsed)

method_declaration (+49 nodes collapsed)

method_declaration (+41 nodes collapsed)

method_declaration

modifiers

marker_annotation

@ "@"

identifier "Override"

public "public"

void_type "void"

identifier "visit"

formal_parameters

( "("

formal_parameter

type_identifier "NodeTraversal"

identifier "t"

, ","

formal_parameter

type_identifier "Node"

identifier "n"

, ","

formal_parameter

type_identifier "Node"

identifier "parent"

) ")"

block

{ "{"

switch_expression

switch "switch"

parenthesized_expression

( "("

method_invocation

identifier "n"

. "."

identifier "getType"

argument_list

( "("

) ")"

switch_block

{ "{"

switch_block_statement_group (+99 nodes collapsed)

switch_block_statement_group

switch_label

case "case"

field_access

identifier "Token"

. "."

identifier "FUNCTION"

: ":"

expression_statement

method_invocation

identifier "normalizeFunctionDeclaration"

argument_list

( "("

identifier "n"

) ")"

; ";"

break_statement

break "break"

; ";"

} "}"

block_comment "/**\n * Rewrite named unhoisted functions declarations to"...

method_declaration

modifiers

private "private"

void_type "void"

identifier "normalizeFunctionDeclaration"

formal_parameters

( "("

formal_parameter

type_identifier "Node"

identifier "n"

) ")"

block

{ "{"

expression_statement

method_invocation

identifier "Preconditions"

. "."

identifier "checkState"

argument_list

( "("

binary_expression

method_invocation

identifier "n"

. "."

identifier "getType"

argument_list

( "("

) ")"

== "=="

field_access

identifier "Token"

. "."

identifier "FUNCTION"

) ")"

; ";"

if_statement

if "if"

parenthesized_expression

( "("

binary_expression

unary_expression

! "!"

method_invocation

identifier "NodeUtil"

. "."

identifier "isFunctionAnonymous"

argument_list

( "("

identifier "n"

) ")"

&& "&&"

unary_expression

! "!"

method_invocation

identifier "NodeUtil"

. "."

identifier "isHoistedFunctionDeclaration"

argument_list

( "("

identifier "n"

) ")"

block

{ "{"

expression_statement

method_invocation

identifier "rewriteFunctionDeclaration"

argument_list

( "("

identifier "n"

) ")"

; ";"

} "}"

block_comment "/**\n * Rewrite the function declaration from:\n * f"...

method_declaration

modifiers

private "private"

void_type "void"

identifier "rewriteFunctionDeclaration"

formal_parameters

( "("

formal_parameter

type_identifier "Node"

identifier "n"

) ")"

block

{ "{"

line_comment "// Prepare a spot for the function."

local_variable_declaration

type_identifier "Node"

variable_declarator

identifier "oldNameNode"

= "="

method_invocation

identifier "n"

. "."

identifier "getFirstChild"

argument_list

( "("

) ")"

; ";"

local_variable_declaration

type_identifier "Node"

variable_declarator

identifier "fnNameNode"

= "="

method_invocation

identifier "oldNameNode"

. "."

identifier "cloneNode"

argument_list

( "("

) ")"

; ";"

local_variable_declaration

type_identifier "Node"

variable_declarator

identifier "var"

= "="

object_creation_expression

new "new"

type_identifier "Node"

argument_list

( "("

field_access

identifier "Token"

. "."

identifier "VAR"

, ","

identifier "fnNameNode"

, ","

method_invocation

identifier "n"

. "."

identifier "getLineno"

argument_list

( "("

) ")"

, ","

method_invocation

identifier "n"

. "."

identifier "getCharno"

argument_list

( "("

) ")"

; ";"

expression_statement

method_invocation

identifier "var"

. "."

identifier "copyInformationFrom"

argument_list

( "("

identifier "n"

) ")"

; ";"

line_comment "// Prepare the function"

expression_statement

method_invocation

identifier "oldNameNode"

. "."

identifier "setString"

argument_list

( "("

string_literal

" "\""

) ")"

; ";"

line_comment "// Move the function"

local_variable_declaration

type_identifier "Node"

variable_declarator

identifier "parent"

= "="

method_invocation

identifier "n"

. "."

identifier "getParent"

argument_list

( "("

) ")"

; ";"

expression_statement

method_invocation

identifier "parent"

. "."

identifier "replaceChild"

argument_list

( "("

identifier "n"

, ","

identifier "var"

) ")"

; ";"

expression_statement

method_invocation

identifier "fnNameNode"

. "."

identifier "addChildToFront"

argument_list

( "("

identifier "n"

) ")"

; ";"

expression_statement

method_invocation

identifier "reportCodeChange"

argument_list

( "("

string_literal

" "\""

string_fragment "Function declaration"

" "\""

) ")"

; ";"

} "}"

block_comment "/**\n * Do normalizations that introduce new siblings or "...

method_declaration (+157 nodes collapsed)

line_comment "// TODO(johnlenz): Move this to NodeTypeNormalizer once the "...

line_comment "// fixed."

block_comment "/**\n * Limit the number of special cases where LABELs ne"...

method_declaration (+163 nodes collapsed)

block_comment "/**\n * Bring the initializers out of FOR loops. These n"...

method_declaration (+298 nodes collapsed)

block_comment "/**\n * Split a var node such as:\n * var a, b;\n "...

method_declaration (+216 nodes collapsed)

block_comment "/**\n * Move all the functions that are valid at the exec"...

method_declaration (+220 nodes collapsed)

block_comment "/**\n * @param after The child node to insert the newChil"...

method_declaration (+64 nodes collapsed)

} "}"

block_comment "/**\n * Remove duplicate VAR declarations.\n */"

method_declaration (+73 nodes collapsed)

block_comment "/**\n * ScopeCreator duplicate declaration handler.\n */"

class_declaration

modifiers

private "private"

final "final"

class "class"

identifier "DuplicateDeclarationHandler"

super_interfaces

implements "implements"

type_list

scoped_type_identifier

type_identifier "SyntacticScopeCreator"

. "."

type_identifier "RedeclarationHandler"

class_body

{ "{"

block_comment "/**\n * Remove duplicate VAR declarations encountered dis"...

method_declaration

modifiers

marker_annotation

@ "@"

identifier "Override"

public "public"

void_type "void"

identifier "onRedeclaration"

formal_parameters (+26 nodes collapsed)

block

{ "{"

expression_statement (+22 nodes collapsed)

local_variable_declaration

type_identifier "Var"

variable_declarator

identifier "v"

= "="

method_invocation

identifier "s"

. "."

identifier "getVar"

argument_list

( "("

identifier "name"

) ")"

; ";"

line_comment "// If name is \"arguments\", Var maybe null."

expression_statement

method_invocation

identifier "Preconditions"

. "."

identifier "checkState"

argument_list

( "("

binary_expression

identifier "v"

== "=="

null_literal "null"

|| "||"

binary_expression

method_invocation

identifier "v"

. "."

identifier "getParentNode"

argument_list

( "("

) ")"

. "."

identifier "getType"

argument_list

( "("

) ")"

!= "!="

field_access

identifier "Token"

. "."

identifier "CATCH"

) ")"

; ";"

if_statement

if "if"

parenthesized_expression

( "("

binary_expression

identifier "v"

!= "!="

null_literal "null"

&& "&&"

binary_expression

method_invocation

identifier "parent"

. "."

identifier "getType"

argument_list

( "("

) ")"

== "=="

field_access

identifier "Token"

. "."

identifier "FUNCTION"

) ")"

block

{ "{"

if_statement

if "if"

parenthesized_expression

( "("

binary_expression

method_invocation

identifier "v"

. "."

identifier "getParentNode"

argument_list

( "("

) ")"

. "."

identifier "getType"

argument_list

( "("

) ")"

== "=="

field_access

identifier "Token"

. "."

identifier "VAR"

) ")"

block

{ "{"

expression_statement

method_invocation

identifier "s"

. "."

identifier "undeclare"

argument_list

( "("

identifier "v"

) ")"

; ";"

expression_statement

method_invocation

identifier "s"

. "."

identifier "declare"

argument_list

( "("

identifier "name"

, ","

identifier "n"

, ","

method_invocation

identifier "n"

. "."

identifier "getJSType"

argument_list

( "("

) ")"

, ","

field_access

identifier "v"

. "."

identifier "input"

) ")"

; ";"

expression_statement

method_invocation

identifier "replaceVarWithAssignment"

argument_list

( "("

method_invocation

identifier "v"

. "."

identifier "getNameNode"

argument_list

( "("

) ")"

, ","

method_invocation

identifier "v"

. "."

identifier "getParentNode"

argument_list

( "("

) ")"

, ","

method_invocation

identifier "v"

. "."

identifier "getParentNode"

argument_list

( "("

) ")"

. "."

identifier "getParent"

argument_list

( "("

) ")"

; ";"

} "}"

else "else"

if_statement

if "if"

parenthesized_expression

( "("

binary_expression

method_invocation

identifier "parent"

. "."

identifier "getType"

argument_list

( "("

) ")"

== "=="

field_access

identifier "Token"

. "."

identifier "VAR"

) ")"

block

{ "{"

expression_statement

method_invocation

identifier "Preconditions"

. "."

identifier "checkState"

argument_list

( "("

method_invocation

identifier "parent"

. "."

identifier "hasOneChild"

argument_list

( "("

) ")"

; ";"

expression_statement

method_invocation

identifier "replaceVarWithAssignment"

argument_list

( "("

identifier "n"

, ","

identifier "parent"

, ","

identifier "gramps"

) ")"

; ";"

} "}"

block_comment "/**\n * Remove the parent VAR. There are three cases that"...

method_declaration (+251 nodes collapsed)

} "}"

block_comment "/**\n * A simple class that causes scope to be created.\n "...

class_declaration (+117 nodes collapsed)

} "}"