cpp-microsoft-terminal-remove-unary-expression-from-binary

This mapping has 1 multi-map group: several pairings are equally correct there. The code view shows one arbitrary valid pairing, not the only one.

A painting is a person's account of this edit as text, recorded independently of the node mapping - a rendering often has several equally defensible answers where the mapping has one. Deletions and insertions carry no position on the opposite side in a painting, so that panel draws no caret for them.

Before…lines 1–363 unchanged (363 lines)
364{
365    _actionMap->ExpandCommands(profiles, schemes);
366}
367
368bool GlobalAppSettings::ShouldUsePersistedLayout() const
369{
370    return FirstWindowPreference() == FirstWindowPreference::PersistedWindowLayout && !IsolatedMode();
371}
372
373void GlobalAppSettings::_logSettingSet(const std::string_view& setting)
374{
375    if (setting == "theme")
376    {
…lines 377–454 unchanged (78 lines)

After…lines 1–363 unchanged (363 lines)
364{
365    _actionMap->ExpandCommands(profiles, schemes);
366}
367
368bool GlobalAppSettings::ShouldUsePersistedLayout() const
369{
370    return FirstWindowPreference() == FirstWindowPreference::PersistedWindowLayout;
371}
372
373void GlobalAppSettings::_logSettingSet(const std::string_view& setting)
374{
375    if (setting == "theme")
376    {
…lines 377–454 unchanged (78 lines)

Before…lines 1–363 unchanged (363 lines)
364{
365    _actionMap->ExpandCommands(profiles, schemes);
366}
367
368bool GlobalAppSettings::ShouldUsePersistedLayout() const
369{
370    return FirstWindowPreference() == FirstWindowPreference::PersistedWindowLayout && !IsolatedMode();
371}
372
373void GlobalAppSettings::_logSettingSet(const std::string_view& setting)
374{
375    if (setting == "theme")
376    {
…lines 377–454 unchanged (78 lines)

After…lines 1–363 unchanged (363 lines)
364{
365    _actionMap->ExpandCommands(profiles, schemes);
366}
367
368bool GlobalAppSettings::ShouldUsePersistedLayout() const
369{
370    return FirstWindowPreference() == FirstWindowPreference::PersistedWindowLayout;
371}
372
373void GlobalAppSettings::_logSettingSet(const std::string_view& setting)
374{
375    if (setting == "theme")
376    {
…lines 377–454 unchanged (78 lines)

Before…lines 1–363 unchanged (363 lines)
364{
365    _actionMap->ExpandCommands(profiles, schemes);
366}
367
368bool GlobalAppSettings::ShouldUsePersistedLayout() const
369{
370    return FirstWindowPreference() == FirstWindowPreference::PersistedWindowLayout && !IsolatedMode();
371}
372
373void GlobalAppSettings::_logSettingSet(const std::string_view& setting)
374{
375    if (setting == "theme")
376    {
…lines 377–454 unchanged (78 lines)

After…lines 1–363 unchanged (363 lines)
364{
365    _actionMap->ExpandCommands(profiles, schemes);
366}
367
368bool GlobalAppSettings::ShouldUsePersistedLayout() const
369{
370    return FirstWindowPreference() == FirstWindowPreference::PersistedWindowLayout;
371}
372
373void GlobalAppSettings::_logSettingSet(const std::string_view& setting)
374{
375    if (setting == "theme")
376    {
…lines 377–454 unchanged (78 lines)

Before

translation_unit

comment "// Copyright (c) Microsoft Corporation.\r"

comment "// Licensed under the MIT license.\r"

preproc_include

#include "#include"

string_literal

" "\""

string_content "pch.h"

" "\""

preproc_include

#include "#include"

string_literal

" "\""

string_content "GlobalAppSettings.h"

" "\""

preproc_include

#include "#include"

string_literal

" "\""

string_content "../../types/inc/Utils.hpp"

" "\""

preproc_include

#include "#include"

string_literal

" "\""

string_content "JsonUtils.h"

" "\""

preproc_include

#include "#include"

string_literal

" "\""

string_content "KeyChordSerialization.h"

" "\""

preproc_include

#include "#include"

string_literal

" "\""

string_content "GlobalAppSettings.g.cpp"

" "\""

preproc_include

#include "#include"

system_lib_string "<LibraryResources.h>"

using_declaration

using "using"

namespace "namespace"

qualified_identifier

namespace_identifier "Microsoft"

:: "::"

qualified_identifier

namespace_identifier "Terminal"

:: "::"

qualified_identifier

namespace_identifier "Settings"

:: "::"

identifier "Model"

; ";"

using_declaration

using "using"

namespace "namespace"

qualified_identifier

namespace_identifier "winrt"

:: "::"

qualified_identifier

namespace_identifier "Microsoft"

:: "::"

qualified_identifier

namespace_identifier "Terminal"

:: "::"

qualified_identifier

namespace_identifier "Settings"

:: "::"

qualified_identifier

namespace_identifier "Model"

:: "::"

identifier "implementation"

; ";"

using_declaration

using "using"

namespace "namespace"

qualified_identifier

namespace_identifier "winrt"

:: "::"

qualified_identifier

namespace_identifier "Windows"

:: "::"

qualified_identifier

namespace_identifier "UI"

:: "::"

identifier "Xaml"

; ";"

using_declaration

using "using"

namespace "namespace"

qualified_identifier

:: "::"

qualified_identifier

namespace_identifier "Microsoft"

:: "::"

identifier "Console"

; ";"

using_declaration

using "using"

namespace "namespace"

qualified_identifier

namespace_identifier "winrt"

:: "::"

qualified_identifier

namespace_identifier "Microsoft"

:: "::"

qualified_identifier

namespace_identifier "UI"

:: "::"

qualified_identifier

namespace_identifier "Xaml"

:: "::"

identifier "Controls"

; ";"

declaration

storage_class_specifier

static "static"

type_qualifier

constexpr "constexpr"

qualified_identifier

namespace_identifier "std"

:: "::"

type_identifier "string_view"

init_declarator

identifier "KeybindingsKey"

initializer_list

{ "{"

string_literal

" "\""

string_content "keybindings"

" "\""

} "}"

; ";"

declaration

storage_class_specifier

static "static"

type_qualifier

constexpr "constexpr"

qualified_identifier

namespace_identifier "std"

:: "::"

type_identifier "string_view"

init_declarator

identifier "ActionsKey"

initializer_list

{ "{"

string_literal

" "\""

string_content "actions"

" "\""

} "}"

; ";"

declaration

storage_class_specifier

static "static"

type_qualifier

constexpr "constexpr"

qualified_identifier

namespace_identifier "std"

:: "::"

type_identifier "string_view"

init_declarator

identifier "ThemeKey"

initializer_list

{ "{"

string_literal

" "\""

string_content "theme"

" "\""

} "}"

; ";"

declaration

storage_class_specifier

static "static"

type_qualifier

constexpr "constexpr"

qualified_identifier

namespace_identifier "std"

:: "::"

type_identifier "string_view"

init_declarator

identifier "DefaultProfileKey"

initializer_list

{ "{"

string_literal

" "\""

string_content "defaultProfile"

" "\""

} "}"

; ";"

declaration

storage_class_specifier

static "static"

type_qualifier

constexpr "constexpr"

qualified_identifier

namespace_identifier "std"

:: "::"

type_identifier "string_view"

init_declarator

identifier "LegacyUseTabSwitcherModeKey"

initializer_list

{ "{"

string_literal

" "\""

string_content "useTabSwitcher"

" "\""

} "}"

; ";"

declaration

storage_class_specifier

static "static"

type_qualifier

constexpr "constexpr"

qualified_identifier

namespace_identifier "std"

:: "::"

type_identifier "string_view"

init_declarator

identifier "LegacyReloadEnvironmentVariablesKey"

initializer_list

{ "{"

string_literal

" "\""

string_content "compatibility.reloadEnvironmentVariables"

" "\""

} "}"

; ";"

declaration

storage_class_specifier

static "static"

type_qualifier

constexpr "constexpr"

qualified_identifier

namespace_identifier "std"

:: "::"

type_identifier "string_view"

init_declarator

identifier "LegacyForceVTInputKey"

initializer_list

{ "{"

string_literal

" "\""

string_content "experimental.input.forceVT"

" "\""

} "}"

; ";"

declaration

storage_class_specifier

static "static"

type_qualifier

constexpr "constexpr"

qualified_identifier

namespace_identifier "std"

:: "::"

type_identifier "string_view"

init_declarator

identifier "LegacyInputServiceWarningKey"

initializer_list

{ "{"

string_literal

" "\""

string_content "inputServiceWarning"

" "\""

} "}"

; ";"

declaration

storage_class_specifier

static "static"

type_qualifier

constexpr "constexpr"

qualified_identifier

namespace_identifier "std"

:: "::"

type_identifier "string_view"

init_declarator

identifier "LegacyWarnAboutLargePasteKey"

initializer_list

{ "{"

string_literal

" "\""

string_content "largePasteWarning"

" "\""

} "}"

; ";"

declaration

storage_class_specifier

static "static"

type_qualifier

constexpr "constexpr"

qualified_identifier

namespace_identifier "std"

:: "::"

type_identifier "string_view"

init_declarator

identifier "LegacyWarnAboutMultiLinePasteKey"

initializer_list

{ "{"

string_literal

" "\""

string_content "multiLinePasteWarning"

" "\""

} "}"

; ";"

declaration

storage_class_specifier

static "static"

type_qualifier

constexpr "constexpr"

qualified_identifier

namespace_identifier "std"

:: "::"

type_identifier "string_view"

init_declarator

identifier "LegacyConfirmCloseAllTabsKey"

initializer_list

{ "{"

string_literal

" "\""

string_content "confirmCloseAllTabs"

" "\""

} "}"

; ";"

comment "// Method Description:\r"

comment "// - Copies any extraneous data from the parent before compl"...

comment "// Arguments:\r"

comment "// - <none>\r"

comment "// Return Value:\r"

comment "// - <none>\r"

function_definition (+151 nodes collapsed)

function_definition (+412 nodes collapsed)

function_definition (+65 nodes collapsed)

preproc_call

preproc_directive "#pragma"

preproc_arg "region DefaultProfile\r"

function_definition (+45 nodes collapsed)

function_definition (+22 nodes collapsed)

preproc_call

preproc_directive "#pragma"

preproc_arg "endregion\r"

function_definition (+38 nodes collapsed)

comment "// Method Description:\r"

comment "// - Create a new instance of this class from a serialized J"...

comment "// Arguments:\r"

comment "// - json: an object which should be a serialization of a Gl"...

comment "// Return Value:\r"

comment "// - a new GlobalAppSettings instance created from the value"...

function_definition (+76 nodes collapsed)

function_definition (+567 nodes collapsed)

function_definition (+159 nodes collapsed)

comment "// Method Description:\r"

comment "// - Adds the given colorscheme to our map of schemes, using"...

comment "// Arguments:\r"

comment "// - scheme: the color scheme to add\r"

comment "// Return Value:\r"

comment "// - <none>\r"

function_definition (+43 nodes collapsed)

function_definition (+27 nodes collapsed)

function_definition (+240 nodes collapsed)

comment "// Method Description:\r"

comment "// - Return the warnings that we've collected during parsing"...

comment "// keybindings. It's possible that the user provided keybi"...

comment "// warnings in them - problems that we should alert the us"...

comment "// recover from.\r"

comment "// Arguments:\r"

comment "// - <none>\r"

comment "// Return Value:\r"

comment "// - <none>\r"

function_definition (+47 nodes collapsed)

comment "// Method Description:\r"

comment "// - Create a new serialized JsonObject from an instance of "...

comment "// Arguments:\r"

comment "// - <none>\r"

comment "// Return Value:\r"

comment "// - the JsonObject representing this instance\r"

function_definition (+255 nodes collapsed)

function_definition (+27 nodes collapsed)

function_definition (+203 nodes collapsed)

function_definition (+43 nodes collapsed)

function_definition (+65 nodes collapsed)

function_definition (+89 nodes collapsed)

function_definition

primitive_type "bool"

function_declarator

qualified_identifier

namespace_identifier "GlobalAppSettings"

:: "::"

identifier "ShouldUsePersistedLayout"

parameter_list

( "("

) ")"

type_qualifier

const "const"

compound_statement

{ "{"

return_statement

return "return"

binary_expression any 2:1

call_expression

identifier "FirstWindowPreference"

argument_list

( "("

) ")"

== "=="

qualified_identifier

namespace_identifier "FirstWindowPreference"

:: "::"

identifier "PersistedWindowLayout"

&& "&&"

unary_expression

! "!"

call_expression

identifier "IsolatedMode"

argument_list

( "("

) ")"

; ";"

} "}"

function_definition (+412 nodes collapsed)

function_definition (+191 nodes collapsed)

function_definition (+90 nodes collapsed)

After

translation_unit

comment "// Copyright (c) Microsoft Corporation.\r"

comment "// Licensed under the MIT license.\r"

preproc_include

#include "#include"

string_literal

" "\""

string_content "pch.h"

" "\""

preproc_include

#include "#include"

string_literal

" "\""

string_content "GlobalAppSettings.h"

" "\""

preproc_include

#include "#include"

string_literal

" "\""

string_content "../../types/inc/Utils.hpp"

" "\""

preproc_include

#include "#include"

string_literal

" "\""

string_content "JsonUtils.h"

" "\""

preproc_include

#include "#include"

string_literal

" "\""

string_content "KeyChordSerialization.h"

" "\""

preproc_include

#include "#include"

string_literal

" "\""

string_content "GlobalAppSettings.g.cpp"

" "\""

preproc_include

#include "#include"

system_lib_string "<LibraryResources.h>"

using_declaration

using "using"

namespace "namespace"

qualified_identifier

namespace_identifier "Microsoft"

:: "::"

qualified_identifier

namespace_identifier "Terminal"

:: "::"

qualified_identifier

namespace_identifier "Settings"

:: "::"

identifier "Model"

; ";"

using_declaration

using "using"

namespace "namespace"

qualified_identifier

namespace_identifier "winrt"

:: "::"

qualified_identifier

namespace_identifier "Microsoft"

:: "::"

qualified_identifier

namespace_identifier "Terminal"

:: "::"

qualified_identifier

namespace_identifier "Settings"

:: "::"

qualified_identifier

namespace_identifier "Model"

:: "::"

identifier "implementation"

; ";"

using_declaration

using "using"

namespace "namespace"

qualified_identifier

namespace_identifier "winrt"

:: "::"

qualified_identifier

namespace_identifier "Windows"

:: "::"

qualified_identifier

namespace_identifier "UI"

:: "::"

identifier "Xaml"

; ";"

using_declaration

using "using"

namespace "namespace"

qualified_identifier

:: "::"

qualified_identifier

namespace_identifier "Microsoft"

:: "::"

identifier "Console"

; ";"

using_declaration

using "using"

namespace "namespace"

qualified_identifier

namespace_identifier "winrt"

:: "::"

qualified_identifier

namespace_identifier "Microsoft"

:: "::"

qualified_identifier

namespace_identifier "UI"

:: "::"

qualified_identifier

namespace_identifier "Xaml"

:: "::"

identifier "Controls"

; ";"

declaration

storage_class_specifier

static "static"

type_qualifier

constexpr "constexpr"

qualified_identifier

namespace_identifier "std"

:: "::"

type_identifier "string_view"

init_declarator

identifier "KeybindingsKey"

initializer_list

{ "{"

string_literal

" "\""

string_content "keybindings"

" "\""

} "}"

; ";"

declaration

storage_class_specifier

static "static"

type_qualifier

constexpr "constexpr"

qualified_identifier

namespace_identifier "std"

:: "::"

type_identifier "string_view"

init_declarator

identifier "ActionsKey"

initializer_list

{ "{"

string_literal

" "\""

string_content "actions"

" "\""

} "}"

; ";"

declaration

storage_class_specifier

static "static"

type_qualifier

constexpr "constexpr"

qualified_identifier

namespace_identifier "std"

:: "::"

type_identifier "string_view"

init_declarator

identifier "ThemeKey"

initializer_list

{ "{"

string_literal

" "\""

string_content "theme"

" "\""

} "}"

; ";"

declaration

storage_class_specifier

static "static"

type_qualifier

constexpr "constexpr"

qualified_identifier

namespace_identifier "std"

:: "::"

type_identifier "string_view"

init_declarator

identifier "DefaultProfileKey"

initializer_list

{ "{"

string_literal

" "\""

string_content "defaultProfile"

" "\""

} "}"

; ";"

declaration

storage_class_specifier

static "static"

type_qualifier

constexpr "constexpr"

qualified_identifier

namespace_identifier "std"

:: "::"

type_identifier "string_view"

init_declarator

identifier "LegacyUseTabSwitcherModeKey"

initializer_list

{ "{"

string_literal

" "\""

string_content "useTabSwitcher"

" "\""

} "}"

; ";"

declaration

storage_class_specifier

static "static"

type_qualifier

constexpr "constexpr"

qualified_identifier

namespace_identifier "std"

:: "::"

type_identifier "string_view"

init_declarator

identifier "LegacyReloadEnvironmentVariablesKey"

initializer_list

{ "{"

string_literal

" "\""

string_content "compatibility.reloadEnvironmentVariables"

" "\""

} "}"

; ";"

declaration

storage_class_specifier

static "static"

type_qualifier

constexpr "constexpr"

qualified_identifier

namespace_identifier "std"

:: "::"

type_identifier "string_view"

init_declarator

identifier "LegacyForceVTInputKey"

initializer_list

{ "{"

string_literal

" "\""

string_content "experimental.input.forceVT"

" "\""

} "}"

; ";"

declaration

storage_class_specifier

static "static"

type_qualifier

constexpr "constexpr"

qualified_identifier

namespace_identifier "std"

:: "::"

type_identifier "string_view"

init_declarator

identifier "LegacyInputServiceWarningKey"

initializer_list

{ "{"

string_literal

" "\""

string_content "inputServiceWarning"

" "\""

} "}"

; ";"

declaration

storage_class_specifier

static "static"

type_qualifier

constexpr "constexpr"

qualified_identifier

namespace_identifier "std"

:: "::"

type_identifier "string_view"

init_declarator

identifier "LegacyWarnAboutLargePasteKey"

initializer_list

{ "{"

string_literal

" "\""

string_content "largePasteWarning"

" "\""

} "}"

; ";"

declaration

storage_class_specifier

static "static"

type_qualifier

constexpr "constexpr"

qualified_identifier

namespace_identifier "std"

:: "::"

type_identifier "string_view"

init_declarator

identifier "LegacyWarnAboutMultiLinePasteKey"

initializer_list

{ "{"

string_literal

" "\""

string_content "multiLinePasteWarning"

" "\""

} "}"

; ";"

declaration

storage_class_specifier

static "static"

type_qualifier

constexpr "constexpr"

qualified_identifier

namespace_identifier "std"

:: "::"

type_identifier "string_view"

init_declarator

identifier "LegacyConfirmCloseAllTabsKey"

initializer_list

{ "{"

string_literal

" "\""

string_content "confirmCloseAllTabs"

" "\""

} "}"

; ";"

comment "// Method Description:\r"

comment "// - Copies any extraneous data from the parent before compl"...

comment "// Arguments:\r"

comment "// - <none>\r"

comment "// Return Value:\r"

comment "// - <none>\r"

function_definition (+151 nodes collapsed)

function_definition (+412 nodes collapsed)

function_definition (+65 nodes collapsed)

preproc_call

preproc_directive "#pragma"

preproc_arg "region DefaultProfile\r"

function_definition (+45 nodes collapsed)

function_definition (+22 nodes collapsed)

preproc_call

preproc_directive "#pragma"

preproc_arg "endregion\r"

function_definition (+38 nodes collapsed)

comment "// Method Description:\r"

comment "// - Create a new instance of this class from a serialized J"...

comment "// Arguments:\r"

comment "// - json: an object which should be a serialization of a Gl"...

comment "// Return Value:\r"

comment "// - a new GlobalAppSettings instance created from the value"...

function_definition (+76 nodes collapsed)

function_definition (+567 nodes collapsed)

function_definition (+159 nodes collapsed)

comment "// Method Description:\r"

comment "// - Adds the given colorscheme to our map of schemes, using"...

comment "// Arguments:\r"

comment "// - scheme: the color scheme to add\r"

comment "// Return Value:\r"

comment "// - <none>\r"

function_definition (+43 nodes collapsed)

function_definition (+27 nodes collapsed)

function_definition (+240 nodes collapsed)

comment "// Method Description:\r"

comment "// - Return the warnings that we've collected during parsing"...

comment "// keybindings. It's possible that the user provided keybi"...

comment "// warnings in them - problems that we should alert the us"...

comment "// recover from.\r"

comment "// Arguments:\r"

comment "// - <none>\r"

comment "// Return Value:\r"

comment "// - <none>\r"

function_definition (+47 nodes collapsed)

comment "// Method Description:\r"

comment "// - Create a new serialized JsonObject from an instance of "...

comment "// Arguments:\r"

comment "// - <none>\r"

comment "// Return Value:\r"

comment "// - the JsonObject representing this instance\r"

function_definition (+255 nodes collapsed)

function_definition (+27 nodes collapsed)

function_definition (+203 nodes collapsed)

function_definition (+43 nodes collapsed)

function_definition (+65 nodes collapsed)

function_definition (+89 nodes collapsed)

function_definition

primitive_type "bool"

function_declarator

qualified_identifier

namespace_identifier "GlobalAppSettings"

:: "::"

identifier "ShouldUsePersistedLayout"

parameter_list

( "("

) ")"

type_qualifier

const "const"

compound_statement

{ "{"

return_statement

return "return"

binary_expression any 2:1

call_expression

identifier "FirstWindowPreference"

argument_list

( "("

) ")"

== "=="

qualified_identifier

namespace_identifier "FirstWindowPreference"

:: "::"

identifier "PersistedWindowLayout"

; ";"

} "}"

function_definition (+412 nodes collapsed)

function_definition (+191 nodes collapsed)

function_definition (+90 nodes collapsed)